Opened 4 years ago

Closed 3 years ago

#17715 closed enhancement (invalid)

Write unit tests for directory_initiate_command_rend

Reported by: teor Owned by:
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords: easy, tor-tests-unit, tor-tests-coverage, isaremoved, tor-03-unspecified-201612
Cc: Actual Points:
Parent ID: Points: 2
Reviewer: Sponsor: SponsorS-can

Description

To do this:

  • Mock connection_connect to do nothing and return 0
  • Mock directory_send_command to do nothing
  • Mock connection_ap_make_link to return a fake connection
    • just return the partner connection that's passed to it?

It would be nice to get this done in 0.2.8, but I think it's more likely to be 0.2.9.

Child Tickets

Change History (7)

comment:1 Changed 4 years ago by nickm

Points: small/medium

comment:2 Changed 4 years ago by nickm

Keywords: tor-tests-unit tor-tests-coverage added; tests removed
Sponsor: SponsorS-can

comment:3 Changed 4 years ago by isabela

Points: small/medium2

comment:4 Changed 4 years ago by isabela

Keywords: isaremoved added
Milestone: Tor: 0.2.9.x-finalTor: 0.2.???

comment:5 Changed 3 years ago by teor

Milestone: Tor: 0.2.???Tor: 0.3.???

Milestone renamed

comment:6 Changed 3 years ago by nickm

Keywords: tor-03-unspecified-201612 added
Milestone: Tor: 0.3.???Tor: unspecified

Finally admitting that 0.3.??? was a euphemism for Tor: unspecified all along.

comment:7 Changed 3 years ago by teor

Resolution: invalid
Status: newclosed

This function has been refactored, so this task is no longer required.

Note: See TracTickets for help on using tickets.