Opened 5 years ago

Closed 5 years ago

#17720 closed defect (fixed)

Switch from displaying "family" field to new "alleged_family" and "effective_family" fields

Reported by: clv Owned by: gsathya
Priority: Medium Milestone:
Component: Metrics/Compass Version:
Severity: Normal Keywords:
Cc: karsten Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Onionoo recently introduced two new fields "alleged_family" and "effective_family" that together contain all entries of the now deprecated "family" field. We should stop displaying "family" and instead display the union of "alleged_family" and "effective_family".

Child Tickets

Change History (4)

comment:1 Changed 5 years ago by clv

See #16961 and #16962 for the discussion of both Atlas and Globe fixes.

comment:2 Changed 5 years ago by clv

Status: newneeds_review

Please see this commit (branch trac-17720). I did a patch to replace the deprecated "family" field with the new "effective_family" field.
I didn't need to do anything about "alleged_family" as compass already makes a filter to consider only mutually listed relays in the "family", and this automatically leaves out non-existent family members.

comment:3 Changed 5 years ago by karsten

Looks good! Merged to master and will deploy as soon as some minor problems with the host are sorted out. Thanks!

comment:4 Changed 5 years ago by karsten

Resolution: fixed
Status: needs_reviewclosed

Minor problems with the host are sorted out, new code is deployed. Closing. Thanks again, clv!

Note: See TracTickets for help on using tickets.