Opened 3 years ago

Closed 3 years ago

#17763 closed defect (fixed)

tor_addr_is_public_for_reject should return 0 for multicast addresses

Reported by: teor Owned by:
Priority: Low Milestone: Tor: 0.2.8.x-final
Component: Core Tor/Tor Version: Tor: unspecified
Severity: Minor Keywords: TorCoreTeam201512
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

This makes the treatment of addresses from other sources consistent with the implementation of get_interface_address6_list.

This might need to be cherry-picked to:

But only once their implementations include tor_addr_is_public_for_reject.

Child Tickets

Change History (4)

comment:1 Changed 3 years ago by teor

Status: newneeds_review

Please see my branch exitpolicy-multicast on https://github.com/teor2345/tor.git
It fixes this issue for master.

It doesn't need to be backported to 0.2.6 or 0.2.7, as neither implementation uses tor_addr_is_public_for_reject. (Also, triggering this issue would require an operator to explicitly configure a multicast address in their torrc, at which point they'd have bigger issues.)

comment:2 Changed 3 years ago by teor

Keywords: TorCoreTeam201512 added

comment:3 Changed 3 years ago by nickm

lgtm; merged!

comment:4 Changed 3 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed
Note: See TracTickets for help on using tickets.