Opened 4 years ago

Closed 4 years ago

#17766 closed enhancement (fixed)

Comment-only changes to tor

Reported by: teor Owned by:
Priority: Medium Milestone: Tor: 0.2.8.x-final
Component: Core Tor/Tor Version: Tor: unspecified
Severity: Trivial Keywords: TorCoreTeam201512
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:


My branch comments-20151204 contains comment-only changes to Tor:

  • get_connection_array no longer takes "n"
  • Move a comment in router_get_my_descriptor to the correct line
  • Update comment for connection_connect
    • port is in host order, addr is a tor_addr_t so endianness is abstracted
    • addr and port can be different from conn->addr and conn->port for proxies
  • connection_get_by_type_addr_port_purpose also ignores connections

that are marked for close

Please see

Child Tickets

Change History (2)

comment:1 Changed 4 years ago by teor

Keywords: TorCoreTeam201512 added
Status: newneeds_review

comment:2 Changed 4 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed


Note: See TracTickets for help on using tickets.