Opened 9 years ago

Closed 9 years ago

#1777 closed defect (worksforme)

TorCtl ExitPolicyLine Deprecation Warning

Reported by: atagar Owned by: mikeperry
Priority: Medium Milestone:
Component: Torctl Version:
Severity: Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Hi, the str method of TorCtl's ExitPolicyLine class has an issue, producing deprecation warnings in python 2.5 and above:

DeprecationWarning: struct integer overflow masking is deprecated

Apparently it's an issue with the method's struct.pack calls. A discussion of the issue and fix are available at:
http://www.groupsrv.com/computers/about360960.html

Cheers! -Damian

Child Tickets

Change History (2)

comment:1 Changed 9 years ago by hbock

Hi Damian,

Are you using the latest git revision of TorCtl? I'm 99% sure I fixed this in pytorctl commit d96f599c6ceeb3ae5e3dfd6f5497fb9003042267 (Fix determination of netmask from CIDR prefix length). If you're still on TorCtl svn, I believe it needs to be synced to git HEAD.

comment:2 Changed 9 years ago by atagar

Resolution: worksforme
Status: newclosed

Ack, sorry. Yes, it's the svn copy though checked the git version and it seemed to be the same. You're probably right so resolving.

No need to sync the svn torctl. I'll be moving to git at some point and we can then deprecate it.

Note: See TracTickets for help on using tickets.