Opened 3 years ago

Closed 3 years ago

#17770 closed defect (fixed)

Buttons on donation banner on about:tor are misaligned sometimes

Reported by: gk Owned by: tbb-team
Priority: High Milestone:
Component: Applications/Tor Browser Version:
Severity: Major Keywords: funding, crowdfunding, donations, TorBrowserTeam201512R
Cc: arthuredelstein Actual Points:
Parent ID: #17534 Points:
Reviewer: Sponsor:

Description

Attached is a screen shot I took showing the donation banner with Laura Poitras and the new about:tor lookout for the alpha releases. There are at least two issues:

1) The buttons on the banner are not properly aligned.
2) While testing not only clicking on the buttons led to the donation page but this happened as well if I clicked somewhere on the banner and even if I clicked somewhere outside of it next to it. While I could live with the second case (although I think we should only go to the donation page if one clicks on the buttons) I am against the behavior in the third case: if one is not clicking on the buttons (banner) one does probably not want to donate and we should respect that.
2a) Probably related there is a little area on the left side next to the banner which seems to have focus as well.

Child Tickets

Attachments (1)

donation_image.png (157.6 KB) - added by gk 3 years ago.

Download all attachments as: .zip

Change History (5)

Changed 3 years ago by gk

Attachment: donation_image.png added

comment:1 Changed 3 years ago by gk

Okay, 1) and 2a) only happen on the Laura Poitras banner while 2) on all of them. (I am fine with opening a different bug for 2) and 2a) if that makes it easier to deal with these issues)

comment:2 Changed 3 years ago by arthuredelstein

Here's a patch that I think fixes these issues. I was debating whether to only activate the buttons, or allow clicking anywhere on the banner lead to the donation page. I'm leaning toward leaving the whole banner link active, because I think some users may click on the banner and not understand why nothing is happening. But I am not 100% sure this is the right answer.

https://github.com/arthuredelstein/torbutton/commit/17770

comment:3 Changed 3 years ago by arthuredelstein

Keywords: TorBrowserTeam201512R added; TorBrowserTeam201512 removed
Status: newneeds_review

comment:4 Changed 3 years ago by gk

Resolution: fixed
Status: needs_reviewclosed

Fine with me, thanks. Applied to master (63699e3da2731c89d1a4e0fbd5e4ba05ea21ff13) and maint-1.9.3 (b2be87834a9f7bde1e1366d6f395d5c068b53ed4). It works fine on all machines (Windows, OS X, Linux) + stable/alpha combinations I could test on.

Note: See TracTickets for help on using tickets.