Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#17781 closed defect (fixed)

New clangs won't build tors

Reported by: nickm Owned by:
Priority: Medium Milestone: Tor: 0.2.4.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Quoth Jenkins:

15:19:59 src/or/connection_edge.c:751:69: error: address of array 'entry_conn->socks_request->address' will always evaluate to 'true' [-Werror,-Wpointer-bool-conversion]
15:19:59           !entry_conn->socks_request || !entry_conn->socks_request->address)
15:19:59                                         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~
15:19:59 1 error generated.

Child Tickets

Change History (3)

comment:1 Changed 4 years ago by nickm

It seems that this behavior is new in clang 3.6.

Tor has been doing this check since at least 0.2.3.

comment:2 Changed 4 years ago by nickm

Resolution: fixed
Status: newclosed

Fixed in 0.2.4 and forward.

comment:3 Changed 4 years ago by teor

(I used to pick these up using clang all the time, apparently the "never NULL" logic in clang just keeps getting better.)

Note: See TracTickets for help on using tickets.