Donation banner translations

Transifex has translated the donation banner to many languages. If we want to include the donation banner in some of these locales, we will need to explicitly activate those locales in the donation banner code. And we will need to adjust the text size and/or layout to accommodate the variation in text length between languages. Which languages should we include?

Finally, we will need to import the latest translations from Transifex before building TBB.

added TorBrowserTeam201512R component::applications/tor browser crowdfunding donations funding owner::tbb-team parent::17534 priority::medium resolution::fixed severity::normal status::closed type::defect labels

Trac:
Keywords: N/A deleted, crowdfunding, funding, TorBrowserTeam201512, donations added

Here's a patch for review. I activated all languages for which the donation banner was fully translated:

https://github.com/arthuredelstein/torbutton/commit/17792

Trac:
Status: new to needs_review
Keywords: TorBrowserTeam201512 deleted, TorBrowserTeam201512R added
Cc: N/A to gk, mcs

Looks good. One nit:

      div = document.getElementById("donation-banner-" + suffix);
      div.innerHTML = text;

You either got the indentation wrong for div.innerHTML = text or wanted to have a "," and not a ";". I am taking the patch as is for the stable hoping that we finally can get a build going. Could you fix that for master?

Trac:
Parent: N/A to #17534 (moved)

This looks OK to Kathy and me as well (with gk's nit noted). I would probably have used a more aggressive ratio (e.g., 0.97) to shrink the font size inside the (0...100) loop, but when Kathy and I tested on Mac OS we saw a maximum of 12 iterations (so it is should be OK as you coded it).

We also notice that some translators translated the people's names; I hope that is OK and correct.

Replying to gk:

Looks good. One nit: {{{ div = document.getElementById("donation-banner-" + suffix); div.innerHTML = text; }}} You either got the indentation wrong for div.innerHTML = text or wanted to have a "," and not a ";". I am taking the patch as is for the stable hoping that we finally can get a build going. Could you fix that for master?

Fortunately it is only an indentation mistake.

https://github.com/arthuredelstein/torbutton/commit/17792+1

Replying to mcs:

This looks OK to Kathy and me as well (with gk's nit noted). I would probably have used a more aggressive ratio (e.g., 0.97) to shrink the font size inside the (0...100) loop, but when Kathy and I tested on Mac OS we saw a maximum of 12 iterations (so it is should be OK as you coded it).

That's true: 0.97 might have been better. I have left it for now in order not to delay things.

We also notice that some translators translated the people's names; I hope that is OK and correct.

I checked with git show 91dc453849badd9 | grep who and there are two such locales included. The Russian locale is using a direct transliteration to Cyrillic. The Simplified Chinese locale has transcribed their names to Chinese characters, while including their original names as well. I tried reversing both back to "English" with Google Translate -- the Russian result is nearly perfect and the Chinese result is interesting.

BTW, I just added Farsi to the list of donation banner languages in the patch for master.

Thanks, applied to master (commit 2faa79edfc674786a062a22a93f95734cdcacf15).

Trac:
Status: needs_review to closed
Resolution: N/A to fixed

closed

mentioned in issue #17816 (moved)

moved to tpo/applications/tor-browser#17792 (closed)