Opened 5 years ago

Last modified 3 years ago

#17793 new defect

Inconsistent function comment cache_failure_intro_lookup

Reported by: cypherpunks Owned by:
Priority: Very Low Milestone: Tor: unspecified
Component: Core Tor/Tor Version: Tor: unspecified
Severity: Trivial Keywords: easy tor-docs comment
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:


The cache_failure_intro_lookup function comment mentions that the intro_entry remains untouched when no entry is found in the rend failure cache. Yet the intro_entry variable is set to NULL right from the start.

We should find out if code depends on this behavior and make the behavior and comment consistent.

Child Tickets

Change History (5)

comment:1 Changed 5 years ago by cypherpunks

The rend_cache_lookup_v2_desc_as_service and rend_cache_lookup_entry have similar comments and are consistent by not touching the entry parameter unless the query returns a result.

comment:2 Changed 4 years ago by teor

Milestone: Tor: 0.2.???Tor: 0.3.???

Milestone renamed

comment:3 Changed 4 years ago by nickm

Keywords: tor-03-unspecified-201612 added
Milestone: Tor: 0.3.???Tor: unspecified

Finally admitting that 0.3.??? was a euphemism for Tor: unspecified all along.

comment:4 Changed 3 years ago by nickm

Keywords: tor-03-unspecified-201612 removed

Remove an old triaging keyword.

comment:5 Changed 3 years ago by nickm

Keywords: easy tor-docs comment added
Note: See TracTickets for help on using tickets.