Opened 9 years ago

Closed 8 years ago

#1780 closed defect (fixed)

Unknown exceptions caught in TorCtl.Connection.read_routers

Reported by: hbock Owned by:
Priority: Medium Milestone:
Component: Torctl Version:
Severity: Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Any exceptions that aren't caught in the try block in Connection.read_routers are printed using the traceback module and ignored. This causes problems when an exception occurs every time get_router is called (e.g., TorCtlClosed), leading to traceback explosion.

Patch attached that removes the except: catch-all, as it seems much better to just let it unwind to the caller.

Child Tickets

Attachments (1)

0001-Don-t-ignore-unknown-exceptions-raised-by-get_router.patch (1.1 KB) - added by hbock 9 years ago.
suggested patch

Download all attachments as: .zip

Change History (4)

Changed 9 years ago by hbock

suggested patch

comment:1 Changed 8 years ago by atagar

Status: newneeds_review

Looks like the status was never set to needing review (maybe we didn't have it back then). Fixing.

comment:2 Changed 8 years ago by mikeperry

Ok. Let's hope this doesn't explode our bw auths and other scanning code :). But otherwise, looks fine to merge.

comment:3 Changed 8 years ago by mikeperry

Resolution: fixed
Status: needs_reviewclosed

Merged.

Note: See TracTickets for help on using tickets.