Opened 4 years ago

Closed 4 years ago

#17804 closed defect (implemented)

Replace usage of INLINE with inline

Reported by: cypherpunks Owned by:
Priority: Low Milestone: Tor: 0.2.8.x-final
Component: Core Tor/Tor Version: Tor: unspecified
Severity: Trivial Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

According to the coding standards document the INLINE keyword should be used in favor of the inline keyword. However, there is still some usage of inline in the Tor code base.

Child Tickets

Attachments (5)

0001-Replace-usage-of-INLINE-with-inline.patch (73.9 KB) - added by cypherpunks 4 years ago.
0002-Remove-obsolete-INLINE-preprocessor-definition.patch (814 bytes) - added by cypherpunks 4 years ago.
0003-Remove-eventdns-specific-inline-definition.patch (723 bytes) - added by cypherpunks 4 years ago.
0004-Remove-the-INLINE-coding-standard.patch (963 bytes) - added by cypherpunks 4 years ago.
0005-Add-changes-file-for-17804.patch (584 bytes) - added by cypherpunks 4 years ago.

Download all attachments as: .zip

Change History (9)

comment:1 Changed 4 years ago by nickm

I think we should revise the coding standards and replace INLINE with inline instead.

(And instead of generating a patch by hand, we should have perl script to do it, eg

 perl -i -pe 's/\bINLINE\b/inline/' src/*/*.[ch] src/*/*/*.[ch]

That will make the patch much easier to review.

comment:2 Changed 4 years ago by nickm

Summary: Replace usage of inline with INLINEReplace usage of INLINE with inline

Changed 4 years ago by cypherpunks

Changed 4 years ago by cypherpunks

Changed 4 years ago by cypherpunks

comment:3 Changed 4 years ago by cypherpunks

Status: newneeds_review

comment:4 Changed 4 years ago by nickm

Resolution: implemented
Status: needs_reviewclosed

Looks fine; merged! (I re-ran the sed command to make sure I got the same results.)

Note: See TracTickets for help on using tickets.