Opened 3 years ago

Last modified 12 months ago

#17806 new enhancement

Make onion queues rational, combine with workqueue logic.

Reported by: nickm Owned by:
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords: intro, term-project-ideas, tor-dos, cpuworker, multithreading, multicore, needs-cs, 034-triage-20180328, 034-removed-20180328
Cc: yawning Actual Points:
Parent ID: Points: 3
Reviewer: Sponsor: SponsorV-can

Description

Right now we have two queues for onions: one before we hand things over to the workqueue, and the workqueue itself.

Soon we'll have a client-side queue for onions, plus the workqueue. (#13737)

Having these extra queues is mildly helpful, since it lets us implement queueing rules more complicated than "first in first out", but it makes our code more complex. Perhaps we should abstract the priority rules and make the workqueue code the only queue we need to care about.

Child Tickets

Change History (27)

comment:1 Changed 3 years ago by nickm

Summary: Make onion queues rationale, combine with workqueue logic.Make onion queues rational, combine with workqueue logic.

comment:2 Changed 3 years ago by nickm

Milestone: Tor: 0.2.8.x-finalTor: 0.2.9.x-final

It is impossible that we will fix all 226 currently open 028 tickets before 028 releases. Time to move some out. This is my second pass through the "new" and tickets, looking for things to move to 0.2.9.

comment:3 Changed 3 years ago by nickm

Keywords: intro added

comment:4 Changed 3 years ago by nickm

Points: medium

comment:5 Changed 3 years ago by nickm

Keywords: 6s194 added

comment:6 Changed 3 years ago by nickm

Keywords: term-project-ideas added; 6s194 removed

These tickets were tagged "6s194" as ideas for possible term projects for students in MIT subject 6.S194 spring 2016. I'm retagging with term-project-ideas, so that the students can use the 6s194 tag for tickets they're actually working on.

comment:7 Changed 3 years ago by isabela

Sponsor: SponsorU-can

comment:8 Changed 3 years ago by nickm

Priority: LowMedium

comment:9 Changed 3 years ago by nickm

Keywords: tor-dos added

comment:10 Changed 3 years ago by isabela

Points: medium3

comment:11 Changed 3 years ago by nickm

Parent ID: #17293

comment:12 Changed 3 years ago by nickm

Milestone: Tor: 0.2.9.x-finalTor: 0.2.???

comment:13 Changed 3 years ago by nickm

Sponsor: SponsorU-can

comment:14 Changed 2 years ago by nickm

Parent ID: #17293

Unparenting these from #17293; holding for future work.

comment:15 Changed 2 years ago by teor

Milestone: Tor: 0.2.???Tor: 0.3.???

Milestone renamed

comment:16 Changed 2 years ago by nickm

Keywords: tor-03-unspecified-201612 added
Milestone: Tor: 0.3.???Tor: unspecified

Finally admitting that 0.3.??? was a euphemism for Tor: unspecified all along.

comment:17 Changed 22 months ago by nickm

Keywords: tor-03-unspecified-201612 removed

Remove an old triaging keyword.

comment:18 Changed 21 months ago by nickm

Keywords: cpuworker multithreading multicore needs-cs added

comment:19 Changed 21 months ago by nickm

Also see #17640.

comment:20 Changed 21 months ago by nickm

This falls out nicely from one of my #22883 fixes

comment:21 Changed 21 months ago by nickm

Milestone: Tor: unspecifiedTor: 0.3.2.x-final

comment:22 Changed 21 months ago by nickm

Sponsor: SponsorV-can

comment:23 Changed 18 months ago by nickm

Milestone: Tor: 0.3.2.x-finalTor: 0.3.3.x-final

comment:24 Changed 14 months ago by nickm

Milestone: Tor: 0.3.3.x-finalTor: 0.3.4.x-final

Deferring various "new"-status enhancement tickets to 0.3.4

comment:25 Changed 12 months ago by nickm

Keywords: 034-triage-20180328 added

comment:26 Changed 12 months ago by nickm

Keywords: 034-removed-20180328 added

Per our triage process, these tickets are pending removal from 0.3.4.

comment:27 Changed 12 months ago by nickm

Milestone: Tor: 0.3.4.x-finalTor: unspecified

These tickets, tagged with 034-removed-*, are no longer in-scope for 0.3.4. We can reconsider any of them, if time permits.

Note: See TracTickets for help on using tickets.