Opened 4 years ago

Closed 4 years ago

#17818 closed defect (fixed)

weird "export"s in Makefile break old BSD make

Reported by: wiz Owned by: cypherpunks
Priority: Medium Milestone: Tor: 0.2.7.x-final
Component: Core Tor/Tor Version: Tor: 0.2.7.5
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

With the 0.2.7.5 (compared to 0.2.6.*) there's a new build problem with older BSD makes.
There is a bug report against pkgsrc in http://gnats.netbsd.org/50521

The problem are weird targets that have:

foo:
export BAR=baz

where the export is not indented with a tab

I'm not sure what's intended here.
They look like empty targets, but then what should the exports do?

In particular:

micro-revision.i
#export TESTING_TOR_BINARY=$(top_builddir)/src/or/tor-cov
export TESTING_TOR_BINARY=$(top_builddir)/src/or/tor

and another few export lines following "FORCE:" about 10 lines below that.

Using newer BSD makes or GNU make is a workaround, but it's not clear
to me what is even the intention here.

Child Tickets

Attachments (5)

Change History (15)

comment:1 Changed 4 years ago by asn

Milestone: Tor: 0.2.8.x-final

comment:2 Changed 4 years ago by cypherpunks

Owner: set to cypherpunks
Status: newaccepted

I already have a patch lying around which uses the TESTS_ENVIRONMENT automake variable to isolate some of the exports from the rest of the build system. I need to update the patch so it includes all exports, make sure it passes make distcheck and has a changes file.

comment:3 Changed 4 years ago by teor

Milestone: Tor: 0.2.8.x-finalTor: 0.2.7.x-final

We might want to backport this to 0.2.7

Changed 4 years ago by cypherpunks

Changed 4 years ago by cypherpunks

comment:4 Changed 4 years ago by cypherpunks

Status: acceptedneeds_review

Here are some patches for review. I'm currently testing whether it works without the use of export. If so, i will attach a fix-up patch.

comment:5 in reply to:  4 Changed 4 years ago by cypherpunks

Replying to cypherpunks:

I'm currently testing whether it works without the use of export. If so, i will attach a fix-up patch.

It didn't work, so no fix-up patch needed.

comment:6 Changed 4 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

Merged these to 0.2.7 and forward. Thank you!

comment:7 Changed 4 years ago by cypherpunks

Resolution: fixed
Status: closedreopened

Builds are failing on wheezy and precise. A new patch is coming to fix these.

comment:8 Changed 4 years ago by cypherpunks

Status: reopenedneeds_review

comment:9 Changed 4 years ago by cypherpunks

Fix up because i noticed a typo in the comment of patch 5.

comment:10 Changed 4 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

both applied.

Note: See TracTickets for help on using tickets.