Opened 3 years ago

Last modified 15 months ago

#17848 new defect

Tor ignores tunneled connections when checking existing directory downloads

Reported by: teor Owned by:
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords: 032-unreached
Cc: ahf, catalyst Actual Points:
Parent ID: Points: 3
Reviewer: Sponsor:

Description

Tor tries to avoid multiple connections to the same directory server to avoid overloading it.

But when checking for existing directory downloads from a server in router_pick_trusteddirserver_impl and router_pick_directory_server_impl, tor ignores connections made via a one-hop ORPort tunnel, and connections made via tor.

This is a hard problem to solve, because ORPort connections can be used for multiple purposes, and can be indirect, so we can't just check the address and port like the existing code does.

Child Tickets

Change History (10)

comment:1 Changed 3 years ago by arma

Really? Shouldn't we have a dir connection on our side, which is going to be linked to a socks connection, which it what induces the OR connection? So all we need to do is check if there's a dir connection?

See in directory_initiate_command_rend() where we do

    linked_conn =
      connection_ap_make_link(...)

comment:2 Changed 2 years ago by nickm

Points: 3

Did we solve this? ISTR merging a bunch of patches about tunneled connections not too long ago.

comment:3 Changed 2 years ago by isabela

Keywords: isaremoved added
Milestone: Tor: 0.2.9.x-finalTor: 0.2.???

comment:4 Changed 2 years ago by teor

Milestone: Tor: 0.2.???Tor: 0.3.???

Milestone renamed

comment:5 Changed 2 years ago by nickm

Keywords: tor-03-unspecified-201612 added
Milestone: Tor: 0.3.???Tor: unspecified

Finally admitting that 0.3.??? was a euphemism for Tor: unspecified all along.

comment:6 Changed 19 months ago by nickm

Keywords: tor-03-unspecified-201612 removed

Remove an old triaging keyword.

comment:7 Changed 19 months ago by nickm

Keywords: isaremoved removed

comment:8 Changed 18 months ago by arma

If this is still a bug, it is a big and important one in terms of bootstrap speed and wasted bootstrap bandwidth.

comment:9 Changed 18 months ago by teor

Cc: ahf catalyst added
Milestone: Tor: unspecifiedTor: 0.3.2.x-final

Ok, so we should check if this is still an issue, and do it under whatever sponsor we are using to do improved bootstrap.

But the chance of selecting the same server at random is still low, right?

comment:10 Changed 15 months ago by nickm

Keywords: 032-unreached added
Milestone: Tor: 0.3.2.x-finalTor: unspecified

Mark a large number of tickets that I do not think we will do for 0.3.2.

Note: See TracTickets for help on using tickets.