Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#17854 closed enhancement (fixed)

Use ClientIPv4 and ClientIPv6 to select a bridge address

Reported by: teor Owned by:
Priority: Low Milestone: Tor: 0.2.9.x-final
Component: Core Tor/Tor Version:
Severity: Minor Keywords: ipv6, bridges, tor-bridge
Cc: Actual Points:
Parent ID: #17963 Points:
Reviewer: Sponsor: SponsorS-can

Description

If a bridge has an IPv4 and an IPv6 address, and a tor client knows both, it should select the address family based on the values of:

  • ClientUseIPv4
  • ClientUseIPv6
  • ClientPreferIPv6ORPort ?

(I don't think ClientPreferIPv6DirPort is relevant here.)

This code works as-is, so I don't see any reason to change it urgently.

Child Tickets

Change History (7)

comment:1 Changed 4 years ago by teor

After #17840, we could do this by modifying the new function fascist_firewall_choose_address_base:

  • use ClientPreferIPv6ORPort to choose a preferred address for bridge clients,
  • but ignore the "preferred address only setting", so that bridge users always get an address if there is one available.

comment:2 Changed 4 years ago by teor

Bridge clients use IPv6 when they can because it's not as censored. I don't think we want to change this. (But perhaps by user config?)

comment:3 Changed 4 years ago by teor

Milestone: Tor: 0.2.9.x-finalTor: 0.2.8.x-final
Parent ID: #17811#17963

#17963 will resolve this as part of making bridge clients use IPv6 for directory queries.

comment:4 Changed 4 years ago by nickm

Milestone: Tor: 0.2.8.x-finalTor: 0.2.9.x-final

It is impossible that we will fix all 226 currently open 028 tickets before 028 releases. Time to move some out. This is my second pass through the "new" and tickets, looking for things to move to 0.2.9.

comment:5 Changed 4 years ago by teor

Resolution: fixed
Status: newclosed

We fixed this in #17840 by making bridge clients:

  • prefer IPv6 by default, and
  • choose directory and OR addresses using the IP family preferences.

I believe this preserves the existing bridge client behaviour, and fixes directory fetches over IPv6.

comment:6 Changed 4 years ago by nickm

Sponsor: SponsorS-can

Tagging these bridge- and PT- items as S-can.

comment:7 Changed 4 years ago by nickm

Keywords: tor-bridge added
Note: See TracTickets for help on using tickets.