Opened 4 years ago

Closed 4 years ago

#17856 closed enhancement (implemented)

change champion on donation page to Shari

Reported by: isabela Owned by: Sebastian
Priority: Medium Milestone:
Component: Webpages/Website Version:
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: #17534 Points:
Reviewer: Sponsor:

Description

Please change the photo and quote to be Shari's. You can use either photo:

350 px wide: https://www.dropbox.com/s/smzjf2u5956tld8/donate-page-ss-350.png?dl=0
700 px wide: https://www.dropbox.com/s/w5w1tzc7us7ai6i/donate-page-ss-700.png?dl=0

And here is the quote:

"Tor is an essential part of the Internet freedom infrastructure, and I'm looking forward to working with the Tor Project to continue to grow the movement."

Child Tickets

Change History (7)

comment:1 Changed 4 years ago by arma

Ok, https://www-staging.torproject.org/donate/donate has an example. Should I move it to the bigger picture? Or is it good as-is?

comment:2 in reply to:  1 Changed 4 years ago by teor

Replying to arma:

Ok, https://www-staging.torproject.org/donate/donate has an example. Should I move it to the bigger picture? Or is it good as-is?

I see the picture about 20 pixels higher than the text/vertical separator.

Is that intentional?

comment:3 Changed 4 years ago by teor

Ah, Roger's photo on the main site is longer, and so it looks good. Shari's photo is shorter, and looks like it's been placed wrong.

comment:4 Changed 4 years ago by arma

css (or wherever) fixes appreciated :)

comment:5 Changed 4 years ago by arma

Ok, it's not css. It's just html inside the donate.wml file, with phrases like class="col-md-8 col-md-offset-0" or style="padding:2px; margin-bottom:10px;".

I think I should leave this to Nima or somebody who knows what all of those options do. :)

comment:6 Changed 4 years ago by mrphs

Status: newneeds_review

The problem was with the ratio of the image, not the CSS. I've re-cropped her photo on this commit: 7794844e26ef78b2d70622eb201d31cd63645c2c

For the future reference, the correct ratio is 3:2

Last edited 4 years ago by mrphs (previous) (diff)

comment:7 Changed 4 years ago by arma

Resolution: implemented
Status: needs_reviewclosed
Type: defectenhancement

Awesome. I've pushed it live. Thanks Nima and all.

Note: See TracTickets for help on using tickets.