Opened 4 years ago

Last modified 2 years ago

#17867 new enhancement

Remove addresses and ports from dir_server_t and just use the ones in fake_status

Reported by: teor Owned by:
Priority: Low Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Minor Keywords: easy, refactor, tor-client SponsorS-deferred
Cc: Actual Points:
Parent ID: Points: small
Reviewer: Sponsor:

Description

We put copies of an AuthDir / FallbackDir's addresses and ports in dir_server_t, and dir_server_t.fake_status. This is just asking for mistakes initialising them.

We could refactor the code so that we always use the addresses and ports in fake_status.

This is not particularly urgent, because dir_server_t is read-only.

Child Tickets

Change History (8)

comment:1 Changed 4 years ago by nickm

Points: small

comment:2 Changed 4 years ago by isabela

Sponsor: SponsorS-can

comment:3 Changed 4 years ago by isabela

Milestone: Tor: 0.2.9.x-finalTor: 0.2.???

tickets market to be removed from milestone 029

comment:4 Changed 4 years ago by nickm

Keywords: SponsorS-deferred added
Sponsor: SponsorS-can

Remove the SponsorS status from these items, which we already decided to defer from 0.2.9. add the SponsorS-deferred tag instead in case we ever want to remember which ones these were.

comment:5 Changed 3 years ago by teor

Milestone: Tor: 0.2.???Tor: 0.3.???

Milestone renamed

comment:6 Changed 3 years ago by nickm

Keywords: tor-03-unspecified-201612 added
Milestone: Tor: 0.3.???Tor: unspecified

Finally admitting that 0.3.??? was a euphemism for Tor: unspecified all along.

comment:7 Changed 3 years ago by nickm

Keywords: tor-03-unspecified-201612 removed

Remove an old triaging keyword.

comment:8 Changed 2 years ago by nickm

Keywords: tor-client added

I'm not 100% sure this is a great idea, but _some kind_ of refactoring on these types sounds like a good idea.

Note: See TracTickets for help on using tickets.