Opened 5 years ago

Closed 5 years ago

#17872 closed enhancement (implemented)

Add support for recently added crypto and for hidden-service statistics

Reported by: karsten Owned by: karsten
Priority: Medium Milestone:
Component: Metrics/Library Version:
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:


We have fallen a bit behind on supported keywords in parsed descriptors, in particular with respect to recently added Ed25519/SHA-256 crypto and hidden-service statistics. Maybe we can catch up before putting out the next release 1.1.0.

I already started working on a branch and will post it here once it's ready for review.

Child Tickets

Change History (3)

comment:1 Changed 5 years ago by karsten

Status: newneeds_review

Please review branch task-17872 in my public repository. I think with those patches we'll again fully support all descriptors available on CollecTor.

comment:2 Changed 5 years ago by iwakeh

looks fine.
(I would have implemented the "stringbuilder" and "switch on string" (for the touched classes) with this patch together, but postponing them is ok, too.)

comment:3 Changed 5 years ago by karsten

Resolution: implemented
Status: needs_reviewclosed

Thanks for looking! Merging to master and resolving.

(I'll start working on the StringBuilder and switch-on-String changes for all of metrics-lib tomorrow, unless you still have local branches that you want to get merged first or unless you're planning to make those changes yourself in the next few days. Happy to make these changes, just trying to avoid duplicating efforts.)

Note: See TracTickets for help on using tickets.