Opened 4 years ago

Closed 4 years ago

#17875 closed defect (fixed)

torrc-defaults gets overwritten during update

Reported by: Unchqua Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Major Keywords: tbb-usability, TorBrowserTeam201512R
Cc: brade, mcs Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

After updating Tor Browser from 5.0.4 to 5.0.5 recently I noticed that my settings in torrc-defaults have all gone and now I have a fresh config file.
While I understand why keeping old config with new software might not be the best way of working, I think it's good to have this file automatically backed up with name like torrc-defaults.orig.1 or similar. May be even give a note on this to user after successful update.
Marked its severity as Major because user can lose all his settings and stay unnoticed until she checks this file later.

Child Tickets

Change History (4)

comment:1 Changed 4 years ago by mcs

Cc: brade mcs added

With Tor Browser, customized settings should be placed in torrc, not torrc-defaults (torrc is preserved across updates).

Maybe we should add a note to torrc-defaults to tell people that though.

comment:2 Changed 4 years ago by Unchqua

My assumption is based on the phrase which is in torrc:

# This file was generated by Tor; if you edit it, comments will not be preserved

For the unexperienced this means that torrc is overwritten easily. In torrc-defaults there are no tips saying what Tor does with it, so a user may think that torrc-defaults is a safer place for manual configuration. I guess Tor (Browser?) must be more precise in wording.

comment:3 Changed 4 years ago by mcs

Keywords: tbb-usability TorBrowserTeam201512R added; torrc-defaults removed
Status: newneeds_review

Here is a change that adds comments to the torrc-defaults files to make it clear that it is not safe to edit it:
https://gitweb.torproject.org/user/brade/tor-browser-bundle.git/commit/?h=bug17875-01&id=940d6ea21668e99619185ef325be39223ffd93ac

comment:4 Changed 4 years ago by gk

Resolution: fixed
Status: needs_reviewclosed

Looks good to me. Applied to master (940d6ea21668e99619185ef325be39223ffd93ac), maint-5.0 (41b71527e0d64a3b14290a82c96014e663f8b93d) and hardened-builds (ac11a0c9cd84d0287ae85fb7357e55535e11f6a9).

Note: See TracTickets for help on using tickets.