#17876 closed defect (fixed)
Connection_ap_about_to_close should call connection_edge_about_to_close.
| Reported by: | nickm | Owned by: | |
|---|---|---|---|
| Priority: | Very High | Milestone: | Tor: 0.2.8.x-final |
| Component: | Core Tor/Tor | Version: | |
| Severity: | Normal | Keywords: | 2016-bug-retrospective |
| Cc: | Actual Points: | ||
| Parent ID: | Points: | ||
| Reviewer: | Sponsor: |
Description
In a2ad31a92, we split connection_about_to_close into separate functions. And we made connection_edge_about_to_close hold the common logic for AP_CONN and EXIT_CONN. But... we never made connection_ap_about_to_close call connection_edge_about_to_close!
This should be harmless in 0.2.7 and earlier, since all connection_edge_about_to_close does is (possibly) generate a warning. But In 0.2.8 for #17590, we shoved a bunch of code in connection_edge_about_to_close that really does matter, for entry connections that are pending circuits.
Bug in 0.2.3.2-alpha.
Child Tickets
Change History (2)
comment:1 Changed 18 months ago by nickm
- Resolution set to fixed
- Status changed from new to closed
comment:2 Changed 14 months ago by nickm
- Keywords 2016-bug-retrospective added
Marking these tickets (based on severity and hand-review) for inclusion in 2016 bug retrospective
Note: See
TracTickets for help on using
tickets.
Fixed in 24fcb6adbb3896395edda38d6ecccb6ad53bddbd