Opened 4 years ago

Last modified 2 years ago

#17881 new enhancement

Use return codes from test programs to simplify test scripts

Reported by: cypherpunks Owned by:
Priority: Low Milestone: Tor: unspecified
Component: Core Tor/Tor Version: Tor: unspecified
Severity: Minor Keywords: tor-testing simplification
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Forwarding the exit codes from the underlying test programs can simplify the test scripts that encapsulate the test programs.

For example, the switch_id test program checks the user id and returns early when we are not root. The test_switch_id.sh script does the same check which is redunant code if we change the return code in the test program and let the script forward it to the test driver.

Other test scripts can be simplified in a similar way.

Child Tickets

Change History (5)

comment:1 Changed 3 years ago by nickm

Milestone: Tor: 0.2.8.x-finalTor: 0.2.???

It is impossible that we will fix all 277 currently open 028 tickets before 028 releases. Time to move some out. This is my first pass through the "new" and "reopened" tickets, looking for things to move to ???.

comment:2 Changed 3 years ago by teor

Milestone: Tor: 0.2.???Tor: 0.3.???

Milestone renamed

comment:3 Changed 3 years ago by nickm

Keywords: tor-03-unspecified-201612 added
Milestone: Tor: 0.3.???Tor: unspecified

Finally admitting that 0.3.??? was a euphemism for Tor: unspecified all along.

comment:4 Changed 2 years ago by nickm

Keywords: tor-03-unspecified-201612 removed

Remove an old triaging keyword.

comment:5 Changed 2 years ago by nickm

Keywords: tor-testing simplification added
Note: See TracTickets for help on using tickets.