Opened 3 years ago

Last modified 2 years ago

#17891 assigned defect

Window classes change after update restart

Reported by: cypherpunks Owned by: mcs
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords:
Cc: brade, mcs, gk Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

When Tor Browser restarts after an update its window classes change from "Navigator" and "Tor Browser" to "Navigator" and "Firefox". I've found these differences with the xprop tool.

I use the i3 window manager and have it configured to make Tor Browser floating based on its window class. After the Tor Browser update restart its window was no longer floating.

The issue does not occur when Tor Browser restarts for a new identity.

Child Tickets

Change History (5)

comment:1 Changed 3 years ago by mcs

Cc: mcs added

The browser process (firefox) does not actually exit during new identity but of course it does exit and restart when an update is applied. I think the problem here is that the window class is set via a command line parameter inside the start-tor-browser script, and command line parameters are not preserved during an update (but we will need to look at the code to be sure). A better approach might be to override the window class in the core browser code.

comment:2 Changed 3 years ago by mcs

See #18199 for a related issue.

comment:3 Changed 3 years ago by mcs

Cc: brade added
Owner: changed from tbb-team to mcs
Status: newassigned

comment:4 Changed 2 years ago by mcs

A couple of people reported this on IRC after the Tor Browser 6.5.1 update.

comment:5 Changed 2 years ago by gk

Cc: gk added
Note: See TracTickets for help on using tickets.