Use sufficient window dimensions in Privacy and Security Settings

The Privacy and Security Settings window dimensions change when the Security Level slider is moved to a higher level to accommodate for the additional information on the right.

The changing of window dimensions distracts from the additional information that is changed because two things happen at the same time.

A solution would be to make the window have sufficient dimensions so it does not need to resize.

added TorBrowserTeam201609R component::applications/tor browser owner::tbb-team priority::low resolution::fixed severity::minor sponsor::U status::closed tbb-security-slider type::defect labels

I see this happen in OS X when I change from medium-high to high: the window becomes slightly longer, and therefore the slider and window content move a little.

Trac:
Cc: N/A to mcs

Trac:
Keywords: N/A deleted, tbb-security-slider added
Cc: mcs to mcs, gk

Why not to allow the user to scale the window as he wants but conserving aspect ratio and internally transform the values visible to webpage (a multiplication and a rounding) in the way it should be indistinguishable from unscaled window.

Getting this on our radar for September.

Trac:
Sponsor: N/A to SponsorU
Keywords: N/A deleted, TorBrowserTeam201609 added

Trac:
Cc: mcs, gk to mcs, gk, arthuredelstein

See also #16211 (moved).

Trac:
Reviewer: N/A to N/A

Here's a patch that adds a scrollbar when the descriptions are too long for the window size. Resizing the window will cause the scrollbar to disappear.

https://github.com/arthuredelstein/torbutton/commit/17904

Trac:
Status: new to needs_review
Keywords: TorBrowserTeam201609 deleted, TorBrowserTeam201609R added

Kathy and I reviewed this and it looks good. We have just a couple of comments:

1. You added ids to many XUL elements, but we do not see where they are used. Are they needed? For example, you added id="privacy_checkboxes" Are these IDs needed?
2. The preferences.xul file has no tabs except for one (which should probably be removed). Please use spaces instead of tabs to stay consistent with the rest of the file.

Replying to mcs:

Kathy and I reviewed this and it looks good. We have just a couple of comments:

Thanks for reviewing this!

1. You added ids to many XUL elements, but we do not see where they are used. Are they needed? For example, you added id="privacy_checkboxes" Are these IDs needed?

I actually added them because I was having trouble keeping track of nested XUL elements. Would you prefer if I turn them into comments?

2. The preferences.xul file has no tabs except for one (which should probably be removed). Please use spaces instead of tabs to stay consistent with the rest of the file.

Not sure how I ended up with tabs -- I will fix that.

Trac:
Status: needs_review to needs_information

Replying to arthuredelstein:

I actually added them because I was having trouble keeping track of nested XUL elements. Would you prefer if I turn them into comments?

Yes, only because when I see an id I think "some code or CSS must reference this element by ID." But if you really like having them I can modify my thinking.

Replying to mcs:

Replying to arthuredelstein:

I actually added them because I was having trouble keeping track of nested XUL elements. Would you prefer if I turn them into comments?

Yes, only because when I see an id I think "some code or CSS must reference this element by ID."

That makes sense. I've dropped them and also got rid of the tabs:

https://github.com/arthuredelstein/torbutton/commit/17904+1

Trac:
Status: needs_information to needs_review

Replying to arthuredelstein:

That makes sense. I've dropped them and also got rid of the tabs:

https://github.com/arthuredelstein/torbutton/commit/17904+1

r=brade, r=mcs This looks good to us.

Applied to master (commit b1adcba17a96a925345001d4da69cb71b469e3ed), thanks.

Trac:
Resolution: N/A to fixed
Status: needs_review to closed

closed

moved to tpo/applications/tor-browser#17904 (closed)