OPENSSL_V_SERIES(1,1,0) compat guard macro borks LibreSSL

Since LibreSSL didn't adapt the whole 'rename everything' policy, it still uses the old names.

changed milestone to %Tor: 0.2.8.x-final

added component::core tor/tor libressl milestone::Tor: 0.2.8.x-final openssl owner::nickm priority::medium resolution::fixed severity::normal status::closed type::defect labels

Trac:
Status: new to accepted
Owner: N/A to nickm
Keywords: N/A deleted, libressl openssl added

I believe be841f77aaa818f445d5b9a5e2eca6aa7ce4f0b6 should have fixed this? Please reopen if not.

Trac:
Resolution: N/A to fixed
Status: accepted to closed

It works for the general building-of-tor sense, but it doesn't cover such as the code guarded in tortls.c and test_tortls.c, such as:

src/test/test_tortls.c:1350:21: error: unused variable 'rbuf_b' [-Werror,-Wunused-variable] size_t rbuf_c=-1, rbuf_b=-1, wbuf_c=-1, wbuf_b=-1; ^ src/test/test_tortls.c:1350:43: error: unused variable 'wbuf_b' [-Werror,-Wunused-variable] size_t rbuf_c=-1, rbuf_b=-1, wbuf_c=-1, wbuf_b=-1; ^ src/test/test_tortls.c:1350:10: error: unused variable 'rbuf_c' [-Werror,-Wunused-variable] size_t rbuf_c=-1, rbuf_b=-1, wbuf_c=-1, wbuf_b=-1; ^ src/test/test_tortls.c:1350:32: error: unused variable 'wbuf_c' [-Werror,-Wunused-variable] size_t rbuf_c=-1, rbuf_b=-1, wbuf_c=-1, wbuf_b=-1; ^ 4 errors generated.

Trac:
Username: cypherpunks-duplicate
Resolution: fixed to N/A
Status: closed to reopened

Could you please attach a complete list of the warnings you get?

Trac:
Status: reopened to needs_information

Those are the only warnings/errors generated with --enable-gcc-warnings --enable-gcc-warnings-advisory --enable-expensive-hardening. I'm also working under the impression that some of the code still guarded by the plain macro, for example inside the functions {tor_tls,test_tortls}_get_buffer_sizes, are applicable to LibreSSL.

Trac:
Status: needs_information to accepted

My branch "openssl_compat" fixes this issue for me, as well and fixing up the unit tests. (See also #17984 (moved).) Tested with libressl-portable 3.2.0, with openssl master, with openssl 1.0.2f, and with openssl 1.0.0t. Please review?

Trac:
Status: accepted to needs_review

Yes, that branch builds cleanly for me against LibreSSL.

Sounds good; merged!

Trac:
Resolution: N/A to fixed
Status: needs_review to closed

closed

mentioned in issue #17984 (moved)

moved to tpo/core/tor#17921 (closed)