Opened 3 years ago

Last modified 2 years ago

#17927 new enhancement

Use SRWLock for non-recursive locks on vista and later

Reported by: nickm Owned by:
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-relay windows win32 api locking easy
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

After WinXP, Windows added the SRWLock type, which is generally much faster than CRITICAL_SECTION, and supports RW semantics. It doesn't support recursive usage, though it can be hacked in.

I'm calling this 0.2.??? since we have no evidence that locking is anywhere close to our critical path. But who knows; perhaps it is? Or will be, once we do more things in workers?

Child Tickets

Change History (4)

comment:1 Changed 3 years ago by teor

Milestone: Tor: 0.2.???Tor: 0.3.???

Milestone renamed

comment:2 Changed 2 years ago by nickm

Keywords: tor-03-unspecified-201612 added
Milestone: Tor: 0.3.???Tor: unspecified

Finally admitting that 0.3.??? was a euphemism for Tor: unspecified all along.

comment:3 Changed 2 years ago by nickm

Keywords: tor-03-unspecified-201612 removed

Remove an old triaging keyword.

comment:4 Changed 2 years ago by nickm

Keywords: tor-relay windows win32 api locking easy added
Note: See TracTickets for help on using tickets.