Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#17963 closed defect (fixed)

Bridge clients should get directory documents via IPv6

Reported by: teor Owned by:
Priority: Medium Milestone: Tor: 0.2.9.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-bridge
Cc: isis Actual Points:
Parent ID: #17840 Points:
Reviewer: Sponsor: SponsorS-can


In directory_get_from_dirserver, a bridge client determines the bridge's address using node_get_addr, which only returns IPv4 addresses.

After #17840 is merged, the bridge client should:

  • respect ClientUseIPv4/6
  • choose a random directory guard that has an available address family (this should just work in choose_random_dirguard after #17840, but we need to check this)
  • choose an address from that dirguard from an available address family

And maybe:

  • respect ClientPreferIPv6OR/DirPort
  • set ClientPreferIPv6OR/DirPort to 1 by default?
    • this will be tricky because these options already have a default value, and we don't want to write it out

Child Tickets

#17854closedUse ClientIPv4 and ClientIPv6 to select a bridge addressCore Tor/Tor

Change History (7)

comment:1 Changed 5 years ago by teor

Parent ID: #17840

#17840 will fix this.

comment:2 Changed 5 years ago by isis

Cc: isis added

comment:3 Changed 5 years ago by nickm

Milestone: Tor: 0.2.8.x-finalTor: 0.2.9.x-final

It is impossible that we will fix all 226 currently open 028 tickets before 028 releases. Time to move some out. This is my second pass through the "new" and tickets, looking for things to move to 0.2.9.

comment:4 Changed 5 years ago by teor

Resolution: fixed
Status: newclosed

We fixed this in #17840 by making bridge clients:

  • prefer IPv6 by default, and
  • choose directory and OR addresses using the IP family preferences.

I believe this preserves the existing bridge client behaviour, and fixes directory fetches over IPv6.

comment:5 Changed 5 years ago by teor

I updated #17840 with one final commit that preserves the previous bridge client behaviour (I got it wrong the first time):

  • bridge clients prefer the configured bridge ORPort address when ClientPreferIPv6ORPort is auto (the default);
  • otherwise, bridge clients prefer ORPort addresses based on ClientPreferIPv6ORPort;
  • other clients prefer IPv4 ORPorts when ClientPreferIPv6ORPort is auto (the default);
  • all clients prefer IPv4 DirPorts when ClientPreferIPv6DirPort is auto (the default).

comment:6 Changed 5 years ago by nickm

Sponsor: SponsorS-can

Tagging these bridge- and PT- items as S-can.

comment:7 Changed 5 years ago by nickm

Keywords: tor-bridge added
Note: See TracTickets for help on using tickets.