Opened 3 years ago

Closed 3 years ago

#18004 closed defect (fixed)

Remove donation banner from TBB about:tor page when campaign is finished

Reported by: arthuredelstein Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: TorBrowserTeam201601R, tbb-5.5
Cc: isabela, boklm Actual Points:
Parent ID: #17534 Points:
Reviewer: Sponsor:

Description

In #17565, we introduced a donation banner to TBB's about:tor page. When the fundraising campaign is done, we should remove the banner from torbutton.git.

Child Tickets

Change History (3)

comment:1 Changed 3 years ago by arthuredelstein

Here's a patch that reverts the commits for the donation banner:

https://github.com/arthuredelstein/torbutton/commit/18004

comment:2 Changed 3 years ago by gk

Cc: boklm added
Keywords: TorBrowserTeam201601R tbb-5.5 added; TorBrowserTeam201601 removed
Status: newneeds_review

FWIW: This will fix the failing dom-objects-enumeration test as well.

comment:3 Changed 3 years ago by gk

Resolution: fixed
Status: needs_reviewclosed

Fixed with commit b079df979ff5d2f2e30324be927edadc3e41aa1f.

Note: See TracTickets for help on using tickets.