Opened 4 years ago

Closed 4 years ago

#18009 closed defect (wontfix)

country-flag-atlas.png reference incorrect in country-flags.css

Reported by: derrickoswald Owned by: isis
Priority: Very Low Milestone:
Component: Metrics/Globe Version:
Severity: Trivial Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:


The reference to the png file containing country flag images is a relative reference to a sibling directory called img, but it should be to a subdirectory. Here is the change that fixes the missing country flags when running standalone (i.e. when double-clicking the index.html file or using Ctrl-O within a browser to open the index.html file):

diff --git a/src/css/country-flags.css b/src/css/country-flags.css
index feddd1e..d9f9fdf 100644
--- a/src/css/country-flags.css
+++ b/src/css/country-flags.css
@@ -2,7 +2,7 @@
-    background:url('../img/country-flag-atlas.png') no-repeat;
+    background:url('img/country-flag-atlas.png') no-repeat;
     display: inline-block;

The effect is to have no country flags visible when running locally. It only works on the web site because the application is deployed at the root of the site and an extra relative .. does nothing.

Child Tickets

Change History (4)

comment:1 Changed 4 years ago by derrickoswald

There are actually three files with incorrect paths. The other two are _loading.scss (for the ajax-loader.gif image) and general.scss (for the globe-logo.png image):

diff --git a/src/css/components/_loading.scss b/src/css/components/_loading.scss
index 85bdc12..84d9133 100644
--- a/src/css/components/_loading.scss
+++ b/src/css/components/_loading.scss
@@ -2,7 +2,7 @@
   padding: 150px 50px 50px 50px;
-  background: url('../img/ajax-loader.gif') no-repeat center center;
+  background: url('img/ajax-loader.gif') no-repeat center center;
     color: $purple;

diff --git a/src/css/general.scss b/src/css/general.scss
index 1ae6011..65e3645 100644
--- a/src/css/general.scss
+++ b/src/css/general.scss
@@ -7,7 +7,7 @@ body, .pure-g [class *= "pure-u"], .pure-g-r [class *= "pure-u"]{
-  background: url('../img/globe-logo.png') no-repeat center center;
+  background: url('img/globe-logo.png') no-repeat center center;
   width: 72px;
   height: 21px;
   display: block;

Last edited 4 years ago by derrickoswald (previous) (diff)

comment:2 Changed 4 years ago by isis

Status: newneeds_information

Hi! Thanks for the bug report.

I'm a little confused what this fixes… The flags seem to display just fine on the deployed version at So, as far as I've understood it, this patch would only work to break the displaying of flags in a developer's locally-running instance?

comment:3 Changed 4 years ago by isis

Keywords: standalone removed

comment:4 Changed 4 years ago by karsten

Resolution: wontfix
Status: needs_informationclosed

We're about to retire Globe, and this issue seems only relevant to Globe and not to Atlas. Closing as won't fix.

Note: See TracTickets for help on using tickets.