Opened 4 years ago

Closed 4 years ago

#18035 closed defect (fixed)

Review proposed fallback directory script fixes

Reported by: teor Owned by: teor
Priority: Medium Milestone: Tor: 0.2.8.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: TorCoreTeam201601
Cc: Actual Points:
Parent ID: #17158 Points:
Reviewer: Sponsor:

Child Tickets

Attachments (1)

updateFallbackDirs.py.patch (4.1 KB) - added by teor 4 years ago.
starlight.2015q3's patch for updateFallbackDirs.py

Download all attachments as: .zip

Change History (5)

Changed 4 years ago by teor

Attachment: updateFallbackDirs.py.patch added

starlight.2015q3's patch for updateFallbackDirs.py

comment:1 Changed 4 years ago by teor

Keywords: TorCoreTeam201601 added
Status: newneeds_review

The attached patch looks sensible, let's get it merged to scripts/maint/updateFallbackDirs.py

comment:2 Changed 4 years ago by teor

Turns out that the patch was based on an old version of the script. I've brought it up to date with the current version in git, and made a minor modification to make the merge easier.

See bug18035 in https://github.com/teor2345/tor.git

comment:3 Changed 4 years ago by teor

Pushed a fixup commit.

Pushed a follow-up commit that only imposes a limit of 500 fallback directories when we're selecting fallbacks for inclusion in tor. (And not when we're listing candidate fallback directories.)

comment:4 Changed 4 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

Merged!

Note: See TracTickets for help on using tickets.