Opened 7 years ago

Closed 3 months ago

#1806 closed defect (wontfix)

Tor warns about config abbreviations every time a controller does an ambiguous getconf

Reported by: atagar Owned by:
Priority: Low Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-client
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

The torrc and GETCONF accepts command abbreviations (for instance "ControlPo" instead of "ControlPort"). This was a mistake since it results in ambiguity for similarly named commands (for instance does "Socks" match "SocksPort" or "SocksBindAddress"?). Hence, use of this is discouraged and results in a warning.

Warnings are emitted in the 'expand_abbrev' function of 'or/config.c' (line 1353). The problem is that this is a getter function, called for a variety of purposes like GETCONF. This means that controllers may accidentally spam users with warnings by requesting an alias repeatedly.

In my opinion the proper handling of this is to either remember the warnings we've given (avoiding duplication), or even better to just provide warnings when reading in the torrc. Cheers! -Damian

Child Tickets

Change History (9)

comment:1 Changed 7 years ago by arma

Component: Tor RelayTor Client

I don't want Tor to remember warnings it's given and suppress them -- imo it should give you the entire set of complaints whenever you do an action that it wants to complain about. Otherwise it's too easy to think "well, it didn't complain that time, so now it's happy".

As for whether to suppress the complaints when the controller does a getconf that it doesn't like... Hm. On the one hand, we want controllers to do up to date things. On the other hand, we don't want to complain for no real reason when you happen to run a not-up-to-date controller on a new Tor.

comment:2 Changed 7 years ago by nickm

Milestone: Tor: 0.2.3.x-final

comment:3 Changed 5 years ago by arma

Summary: Multiple Warnings Emmitted for Config AbbreviationsTor warns about config abbreviations every time a controller does a dangerous getconf

comment:4 Changed 5 years ago by arma

Summary: Tor warns about config abbreviations every time a controller does a dangerous getconfTor warns about config abbreviations every time a controller does an ambiguous getconf

comment:5 Changed 5 years ago by nickm

Milestone: Tor: 0.2.3.x-finalTor: unspecified

comment:6 Changed 5 years ago by nickm

Keywords: tor-client added

comment:7 Changed 5 years ago by nickm

Component: Tor ClientTor

comment:8 Changed 3 years ago by arma

Should we close this ticket?

Atagar, is this still an issue?

comment:9 Changed 3 months ago by nickm

Resolution: wontfix
Severity: Normal
Status: newclosed
Note: See TracTickets for help on using tickets.