Opened 5 years ago

Closed 5 years ago

#18066 closed defect (fixed)

obfs3 transport is broken in Tor Browser nightlies

Reported by: gk Owned by: yawning
Priority: Medium Milestone:
Component: Archived/Obfsproxy Version:
Severity: Normal Keywords:
Cc: asn, yawning Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

While testing my fix for #17428 I stumbled over broken obfs3 in our nightly builds:

Jan 15 11:34:14.000 [warn] 2 connections have failed:
Jan 15 11:34:14.000 [warn] 1 connections died in state handshaking (TLS) with SSL state SSLv2/v3 read server hello A in HANDSHAKE
Jan 15 11:34:14.000 [warn] 1 connections died in state handshaking (proxy) with SSL state (No SSL object)
Jan 15 11:34:14.000 [warn] The connection to the SOCKS5 proxy server at 127.0.0.1:45701 just failed. Make sure that the proxy server is up and running.

Nightlies can be found on https://people.torproject.org/~linus/builds/

Child Tickets

Change History (5)

comment:1 Changed 5 years ago by yawning

Is this all obfs3 bridges, or just "some of the bridges in our default list are kapput"?

I haven't changed the code there at all in a while, so I'd be surprised if it randomly just broke.

comment:2 in reply to:  1 Changed 5 years ago by gk

Replying to yawning:

Is this all obfs3 bridges, or just "some of the bridges in our default list are kapput"?

So, this is interesting. If I make sure we only have one default bridge available (by commenting the respective 4 other ones out) then this works. Basically for any of the default bridges (although the second and the third ones don't really want to talk). However, if I just take the default nightly with non of the 5 default bridges commented out using obfs3 is broken. This does not happen with our 5.5a6. So, I'd assume this has nothing to do with the default bridges we ship.

comment:3 Changed 5 years ago by yawning

I haven't changed anything of note recently, though I guess I can look into this over the weekend.

comment:4 in reply to:  3 Changed 5 years ago by yawning

Owner: changed from asn to yawning
Status: newassigned

Replying to yawning:

I haven't changed anything of note recently, though I guess I can look into this over the weekend.

Sorry for the delay. Someone else reported something that might have caused this behavior with the github issue tracker, and I just merged their patch and committed similar fixes for the other affected transports.

I'll make sure things work as expected next, but if this was it, it won't affect anything built with a tagged release, since the bug was introduced when I integrated the lightweight meek client.

See: https://github.com/Yawning/obfs4/pull/18

Note: See TracTickets for help on using tickets.