Add support for displaying client Tor traffic in Wireshark and similar

I was under the mistaken impression that this patch had already been merged last year. No idea why I thought that.

See also https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3203

changed milestone to %Tor: unspecified

added component::core tor/tor milestone::Tor: unspecified owner::mwenge priority::medium resolution::wontfix severity::normal status::closed tor-client type::enhancement version::tor unspecified labels

Patch at https://gitweb.torproject.org/hoganrobert/tor.git/shortlog/refs/heads/bug1807

Trac:
Version: N/A to Tor: unspecified
Status: new to needs_review
Component: - Select a component to Tor - Tor client

Trac:
Owner: N/A to mwenge
Status: needs_review to assigned

Trac:
Status: assigned to needs_review

Trac:
Milestone: N/A to Tor: post 0.2.2.x

Trac:
Milestone: Tor: post 0.2.2.x to Tor: unspecified

As an idea, maybe this should option should require a private network?

We should talk about this more in January, or whenever works. I am leery of merging this code into the mainline at all. It's useful for experimenting, and we should definitely point researchers at it, but I worry that shipping Tor with a "dump all your keys" mode would send entirely the wrong message to our users and operators.

I looked at this patch a while ago, and had the same initial impression as nickm.

It looks like the patch is pretty modular overall, meaning it probably won't become a broken patch very quickly.

How about we change tor_tls_set_logged_address() so it takes a port argument, and then it dups "address:port" into the tls->address field rather than just "address"? That would decrease the size of the patch and increase its robustness to changes in the Tor code.

The next question is: where should we store the patch so researchers will actually find it? The 'research' page perhaps? But again, I'm not thrilled with having it in the first set of things people see when they think of Tor and research. :(

This patch is going to break in the crypto migration this year.

Also, this ticket looks like it's headed for ‘wontfix’.

Trac:
Status: needs_review to needs_revision
Points: N/A to N/A
Actualpoints: N/A to N/A

Trac:
Keywords: N/A deleted, tor-client added

Trac:
Component: Tor Client to Tor

Trac:
Resolution: N/A to wontfix
Sponsor: N/A to N/A
Severity: N/A to Normal
Reviewer: N/A to N/A
Status: needs_revision to closed

closed

moved to tpo/core/tor#1807 (closed)