Opened 4 years ago

Closed 4 years ago

#18096 closed defect (fixed)

test_options_validate__control fails on Windows because there are no ControlSockets

Reported by: teor Owned by:
Priority: Medium Milestone: Tor: 0.2.8.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: easy
Cc: Actual Points:
Parent ID: #17076 Points:
Reviewer: Sponsor:

Description

This is another issue with #17076.

Windows does not have unix sockets, so the error message and return value should be different.

https://jenkins.torproject.org/job/tor-ci-mingwcross-test/501/ARCHITECTURE=amd64,SUITE=jessie/console

02:58:18 options/validate__control: [forking] fixme:toolhelp:CreateToolhelp32Snapshot Unimplemented: heap list snapshot
02:58:18 fixme:toolhelp:Heap32ListFirst : stub
02:58:18 fixme:toolhelp:CreateToolhelp32Snapshot Unimplemented: heap list snapshot
02:58:18 fixme:toolhelp:Heap32ListFirst : stub
02:58:18 fixme:toolhelp:CreateToolhelp32Snapshot Unimplemented: heap list snapshot
02:58:18 fixme:toolhelp:Heap32ListFirst : stub
02:58:18 
02:58:18   FAIL src/test/test_options.c:3230: assert(ret OP_EQ 0): -1 vs 0
02:58:18   [validate__control FAILED]

Child Tickets

Change History (3)

comment:1 Changed 4 years ago by teor

Keywords: easy added

comment:2 Changed 4 years ago by teor

Parent ID: #17076

comment:3 Changed 4 years ago by nickm

Resolution: fixed
Status: newclosed

Merged the fix from #17076.

Note: See TracTickets for help on using tickets.