Replace getsockname with tor_getsockname

There's a lot of duplicate code in Tor that calls getsockname, then stuffs the address in a tor_addr_t.

Let's cleanup that code by replacing it with tor_getsockname where that makes sense.

For example, in #18100 (moved), we left behind duplicate code in destination_from_socket, because it was a backport, and the changes required to deduplicate it were complex.

changed milestone to %Tor: 0.3.4.x-final

added api code-simplification component::core tor/tor easy intro milestone::Tor: 0.3.4.x-final owner::eewayhsu points::small priority::medium resolution::implemented reviewer::dgoulet severity::normal status::closed type::enhancement labels

It is impossible that we will fix all 277 currently open 028 tickets before 028 releases. Time to move some out. This is my first pass through the "new" and "reopened" tickets, looking for things to move to ???.

Trac:
Milestone: Tor: 0.2.8.x-final to Tor: 0.2.???

Trac:
Keywords: easy deleted, easy intro added

Trac:
Points: N/A to small

Trac:
Username: eewayhsu
Status: new to assigned
Owner: N/A to eewayhsu

Milestone renamed

Trac:
Milestone: Tor: 0.2.??? to Tor: 0.3.???

Finally admitting that 0.3.??? was a euphemism for Tor: unspecified all along.

Trac:
Milestone: Tor: 0.3.??? to Tor: unspecified
Keywords: easy intro deleted, tor-03-unspecified-201612, intro, easy added

Remove an old triaging keyword.

Trac:
Keywords: tor-03-unspecified-201612 deleted, N/A added

Trac:
Reviewer: N/A to N/A
Keywords: N/A deleted, api, code-simplification added

Trac:
Username: callumw

0001-changed-getsockname-calls-to-tor_getsockname.patch

renamed all references to getsockname() to use the tor_getsockname() wrapper function

Trac:
Username: callumw

Trac:
Username: callumw
Status: assigned to needs_review

Trac:
Milestone: Tor: unspecified to Tor: 0.3.3.x-final

I don't think that's what we're going for here. The idea was to change tor_getsockname, or to create a new wrapper for tor_getsockname, so that it would put its result into a tor_addr_t rather than into a struct sockaddr.

Trac:
Status: needs_review to needs_revision

Okay I see what is needed now. I think I dove into this ticket without fully understanding it. Cheers.

Trac:
Username: callumw

Would this suffice for a new tor_getsockname function?

MOCK_IMPL(int, tor_getsockname,(tor_socket_t sock, struct sockaddr *sock_address, tor_addr_t *tor_address, socklen_t *address_len)) { if (getsockname(sock, address, address_len) < 0) { return -1 }

return tor_addr_from_sockaddr(&tor_address, (struct sockaddr*)&sock_address, NULL); }

I have done it this way so that each call to tor_getsockname can be dealt with individually as they are now with getsockname.

Trac:
Username: callumw

The idea would be to have a new, different function that only outputs the tor_addr_t -- not the sockaddr or the address_len.

Replying to nickm:

The idea would be to have a new, different function that only outputs the tor_addr_t -- not the sockaddr or the address_len.

So would we want to pass the sockaddr and address_len by value instead of by reference? Otherwise I do not know another way to derive the tor_addr_t.

Cheers

Trac:
Username: callumw

I am finding it challenging to figure out the best way to solve this problem. I think that's perhaps due to my lack of understanding of the code-base and the context of the enhancement. Is there a good way for me to get assistance with this?

Thanks

Trac:
Username: callumw