Opened 19 months ago

Last modified 8 weeks ago

#18105 assigned enhancement

Replace getsockname with tor_getsockname

Reported by: teor Owned by: eewayhsu
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords: easy, intro, api, code-simplification
Cc: Actual Points:
Parent ID: Points: small
Reviewer: Sponsor:


There's a lot of duplicate code in Tor that calls getsockname, then stuffs the address in a tor_addr_t.

Let's cleanup that code by replacing it with tor_getsockname where that makes sense.

For example, in #18100, we left behind duplicate code in destination_from_socket, because it was a backport, and the changes required to deduplicate it were complex.

Child Tickets

Change History (8)

comment:1 Changed 19 months ago by nickm

Milestone: Tor: 0.2.8.x-finalTor: 0.2.???

It is impossible that we will fix all 277 currently open 028 tickets before 028 releases. Time to move some out. This is my first pass through the "new" and "reopened" tickets, looking for things to move to ???.

comment:2 Changed 19 months ago by nickm

Keywords: intro added

comment:3 Changed 19 months ago by nickm

Points: small

comment:4 Changed 19 months ago by eewayhsu

Owner: set to eewayhsu
Status: newassigned

comment:5 Changed 9 months ago by teor

Milestone: Tor: 0.2.???Tor: 0.3.???

Milestone renamed

comment:6 Changed 8 months ago by nickm

Keywords: tor-03-unspecified-201612 added
Milestone: Tor: 0.3.???Tor: unspecified

Finally admitting that 0.3.??? was a euphemism for Tor: unspecified all along.

comment:7 Changed 3 months ago by nickm

Keywords: tor-03-unspecified-201612 removed

Remove an old triaging keyword.

comment:8 Changed 8 weeks ago by nickm

Keywords: api code-simplification added
Note: See TracTickets for help on using tickets.