Opened 3 years ago

Last modified 2 years ago

#18117 new defect

When stem calls controller.close_circuit(circuit_id), circuits don't really close

Reported by: teor Owned by:
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-control needs-analysis mystery circuit-lifetime
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

I'm using master (0.2.8-alpha-dev) and a stem script similar to the example custom_path_selection.py, but that calls controller.close_circuit(circuit_id) after using each circuit.

This may be related to the abort in #18116.

I get a lot of messages similar to this:

[notice] No circuits are opened. Relaxed timeout for circuit 170239 (a Circuit made by controller 3-hop circuit in state doing handshakes with channel state open) to 60000ms. However, it appears the circuit has timed out anyway. 20 guards are live. [59 similar message(s) suppressed in last 3600 seconds]

It may be that the log message is just wrong, or it may be that stem isn't doing the right thing to close the circuit, or it may be that tor isn't really cleaning up well after controller circuits. The abort in #18116 suggests the latter.

Child Tickets

TicketStatusOwnerSummaryComponent
#18116closedandreaabort in circuitmux_detach_all_circuits on Tor Browser exit with stem scripts runningCore Tor/Tor

Change History (8)

comment:1 Changed 3 years ago by atagar

or it may be that stem isn't doing the right thing to close the circuit

For what it's worth all Stem does is call CLOSECIRCUIT (code).

comment:2 Changed 3 years ago by teor

Another message seen frequently is:

00:12.000 [warn] Couldn't find circuit 2162585894 (for channel 599)

comment:3 Changed 3 years ago by nickm

Milestone: Tor: 0.2.8.x-finalTor: 0.2.9.x-final

It is impossible that we will fix all 226 currently open 028 tickets before 028 releases. Time to move some out. This is my second pass through the "new" and tickets, looking for things to move to 0.2.9.

comment:4 Changed 3 years ago by isabela

Milestone: Tor: 0.2.9.x-finalTor: 0.2.???

tickets market to be removed from milestone 029

comment:5 Changed 3 years ago by teor

Milestone: Tor: 0.2.???Tor: 0.3.???

Milestone renamed

comment:6 Changed 2 years ago by nickm

Keywords: tor-03-unspecified-201612 added
Milestone: Tor: 0.3.???Tor: unspecified

Finally admitting that 0.3.??? was a euphemism for Tor: unspecified all along.

comment:7 Changed 2 years ago by nickm

Keywords: tor-03-unspecified-201612 removed

Remove an old triaging keyword.

comment:8 Changed 2 years ago by nickm

Keywords: tor-control needs-analysis mystery circuit-lifetime added
Note: See TracTickets for help on using tickets.