Changes between Initial Version and Version 1 of Ticket #18119, comment 7


Ignore:
Timestamp:
Jan 22, 2016, 10:33:02 AM (4 years ago)
Author:
azazar
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #18119, comment 7

    initial v1  
    1 Replying to [comment:4 yawning]:
     1Replying to [comment:4 yawning]:
    22
    3 
    4 > I don't think we use `alloca()` in the code, and it feels gratuitious when a pair of statically sized buffers will suffice.
    5 >
    6 > Blindly truncating down addresses assuming the shorted format when doing the comparsion probably leads to odd things happening to existing deployed HSes that happen to have a stream of `a`s at the end.
     3> Blindly truncating down addresses assuming the shorted format when doing the comparsion probably leads to odd things happening to existing deployed HSes that happen to have a stream of `a`s at the end.
    74
    85Actually, this patch is backwards-compatible, all existing addresses should work as they did before. It translates only shortened addresses. What kind of odd things could happen?