Opened 3 years ago

Last modified 2 years ago

#18124 new enhancement

We never use interface names on Windows, avoid retrieving them

Reported by: teor Owned by:
Priority: Very Low Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-client win32 easy windows api
Cc: Actual Points:
Parent ID: Points: small
Reviewer: Sponsor:

Description

We're scanning local interfaces more often in the tor codebase, so it would be a good idea to optimise get_interface_addresses_win32().

We never use the interface names, so let's avoid retrieving them by passing GAA_FLAG_SKIP_FRIENDLY_NAME in FLAGS.

Reference documentation:
https://msdn.microsoft.com/en-us/library/windows/desktop/aa365915%28v=vs.85%29.aspx

Child Tickets

Change History (7)

comment:1 Changed 3 years ago by nickm

Milestone: Tor: 0.2.8.x-finalTor: 0.2.???

It is impossible that we will fix all 277 currently open 028 tickets before 028 releases. Time to move some out. This is my first pass through the "new" and "reopened" tickets, looking for things to move to ???.

comment:2 Changed 3 years ago by nickm

Priority: MediumVery Low

comment:3 Changed 3 years ago by nickm

Points: small

comment:4 Changed 3 years ago by teor

Milestone: Tor: 0.2.???Tor: 0.3.???

Milestone renamed

comment:5 Changed 3 years ago by nickm

Keywords: tor-03-unspecified-201612 added
Milestone: Tor: 0.3.???Tor: unspecified

Finally admitting that 0.3.??? was a euphemism for Tor: unspecified all along.

comment:6 Changed 2 years ago by nickm

Keywords: tor-03-unspecified-201612 removed

Remove an old triaging keyword.

comment:7 Changed 2 years ago by nickm

Keywords: tor-client win32 windows api added; performance removed
Note: See TracTickets for help on using tickets.