Update RSOS extend_info_from_node calls to be direct connections

In rend_consider_services_intro_points() and find_rp_for_intro(), a RSOS calls extend_info_from_node() to get the node's address. Since it's making a direct connection, it should pass 1.

This will enforce IP address preferences and other reachable address settings once #17840 (moved) is merged.

Hidden services should continue to pass 0.

changed milestone to %Tor: 0.2.9.x-final

added component::core tor/tor milestone::Tor: 0.2.9.x-final owner::teor parent::17178 points::1 priority::medium resolution::fixed rsos severity::normal status::closed tor-hs type::defect labels

It is impossible that we will fix all 226 currently open 028 tickets before 028 releases. Time to move some out. This is my second pass through the "new" and tickets, looking for things to move to 0.2.9.

Trac:
Milestone: Tor: 0.2.8.x-final to Tor: 0.2.9.x-final

Trac:
Owner: N/A to teor
Keywords: rsos deleted, rsos TorCoreTeam201602 added
Status: new to assigned
Parent: #17178 (moved) to #17788 (moved)
Milestone: Tor: 0.2.9.x-final to Tor: 0.2.8.x-final

Trac:
Keywords: rsos TorCoreTeam201602 deleted, rsos TorCoreTeam201602 tor-hs added

Revised as part of #17178 (moved).

Trac:
Status: assigned to needs_review

Trac:
Reviewer: N/A to N/A
Keywords: rsos TorCoreTeam201602 tor-hs deleted, rsos tor-hs added
Milestone: Tor: 0.2.8.x-final to Tor: 0.2.9.x-final

Trac:
Points: N/A to small
Keywords: rsos tor-hs deleted, rsos, tor-hs added

Every postponed needs_review ticket should get a review in April

Trac:
Keywords: N/A deleted, TorCoreTeam201604 added

Not sure that ticket should be in needs_review here because 1) RSOS is not merged upstream afaik and 2) I don't see any code to review :).

Putting it back in new state and out of the April work.

Trac:
Status: needs_review to new
Keywords: TorCoreTeam201604 deleted, N/A added

Trac:
Points: small to 1

This is resolved in #17178 (moved)

Trac:
Status: new to closed
Parent: #17788 (moved) to #17178 (moved)
Resolution: N/A to fixed

closed

changed time estimate to 8h

moved to tpo/core/tor#18126 (closed)