Opened 4 years ago

Closed 4 years ago

#18126 closed defect (fixed)

Update RSOS extend_info_from_node calls to be direct connections

Reported by: teor Owned by: teor
Priority: Medium Milestone: Tor: 0.2.9.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: rsos, tor-hs
Cc: Actual Points:
Parent ID: #17178 Points: 1
Reviewer: Sponsor:

Description

In rend_consider_services_intro_points() and find_rp_for_intro(), a RSOS calls extend_info_from_node() to get the node's address. Since it's making a direct connection, it should pass 1.

This will enforce IP address preferences and other reachable address settings once #17840 is merged.

Hidden services should continue to pass 0.

Child Tickets

Change History (10)

comment:1 Changed 4 years ago by nickm

Milestone: Tor: 0.2.8.x-finalTor: 0.2.9.x-final

It is impossible that we will fix all 226 currently open 028 tickets before 028 releases. Time to move some out. This is my second pass through the "new" and tickets, looking for things to move to 0.2.9.

comment:2 Changed 4 years ago by teor

Keywords: TorCoreTeam201602 added
Milestone: Tor: 0.2.9.x-finalTor: 0.2.8.x-final
Owner: set to teor
Parent ID: #17178#17788
Status: newassigned

comment:3 Changed 4 years ago by dgoulet

Keywords: tor-hs added

comment:4 Changed 4 years ago by teor

Status: assignedneeds_review

Revised as part of #17178.

comment:5 Changed 4 years ago by dgoulet

Keywords: TorCoreTeam201602 removed
Milestone: Tor: 0.2.8.x-finalTor: 0.2.9.x-final

comment:6 Changed 4 years ago by dgoulet

Keywords: rsos tor-hsrsos, tor-hs
Points: small

comment:7 Changed 4 years ago by nickm

Keywords: TorCoreTeam201604 added

Every postponed needs_review ticket should get a review in April

comment:8 Changed 4 years ago by dgoulet

Keywords: TorCoreTeam201604 removed
Status: needs_reviewnew

Not sure that ticket should be in needs_review here because 1) RSOS is not merged upstream afaik and 2) I don't see any code to review :).

Putting it back in new state and out of the April work.

comment:9 Changed 4 years ago by isabela

Points: small1

comment:10 Changed 4 years ago by teor

Parent ID: #17788#17178
Resolution: fixed
Status: newclosed

This is resolved in #17178

Note: See TracTickets for help on using tickets.