Opened 5 years ago

Closed 5 years ago

#18132 closed enhancement (fixed)

options_validate: add ClientUseIPv4 unit tests and update other unit tests

Reported by: teor Owned by: teor
Priority: Medium Milestone: Tor: 0.2.8.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: TorCoreTeam201602
Cc: Actual Points:
Parent ID: #17840 Points:
Reviewer: Sponsor:


#17076 adds unit tests for options_validate. It's been merged to master.

#17840 adds ClientUseIPv4 and ClientPreferIPv6DirPort, and changes the meaning of other options. It was based off pre-#17076 master.

This ticket is for updating the unit tests after #17840 merges.

Child Tickets

Change History (7)

comment:1 Changed 5 years ago by teor

Owner: set to teor
Status: newassigned

comment:2 Changed 5 years ago by teor

Parent ID: #17840

Fixed in #17840 in feature17840-v11-merged.

comment:3 Changed 5 years ago by teor

Resolution: fixed
Status: assignedclosed

comment:4 Changed 5 years ago by teor

Resolution: fixed
Status: closedreopened

comment:5 Changed 5 years ago by teor

Keywords: TorCoreTeam201602 added; TorCoreTeam201601 removed
Status: reopenedneeds_review

My branch feature17840-v11-tests cherry picks ae6c5e8 from #17076, then uses it to write unit tests for ClientUseIPv4 and ClientPreferIPv6[OR,Dir]Port.

It also contains another correctness fix for the unit tests in a separate commit.

comment:6 Changed 5 years ago by teor

I updated feature17840-v11-tests with a final commit to preserve current bridge client behaviour. See #17840 for details.

comment:7 Changed 5 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

okay, this was a little weird to get correctly merged, but it seems to have gone okay. I didn't take the final commit on the branch, since it was the same as one in #17840. Please check and let me know if I messed up?

Note: See TracTickets for help on using tickets.