Opened 4 years ago

Closed 3 years ago

#18185 closed defect (fixed)

Fix coding style according to PEP8

Reported by: cypherpunks Owned by: cypherpunks
Priority: Medium Milestone:
Component: Core Tor/Chutney Version:
Severity: Normal Keywords: TorCoreTeam201606
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor: SponsorS-can

Description

The pep8 tool shows several minor PEP8 violations. Fixing these violations would makes it easier for future developers (including me) to check whether their patches are according to the PEP8 without having to ignore existing violations. Also having existing violations gives future developers less incentive to fix violations they introduce.

Child Tickets

Attachments (4)

0001-Fix-PEP8-errors.patch (23.9 KB) - added by cypherpunks 4 years ago.
0002-Remove-trailing-spaces.patch (1.7 KB) - added by cypherpunks 4 years ago.
0001-Fix-PEP8-errors.2.patch (23.9 KB) - added by cypherpunks 3 years ago.
0002-Remove-trailing-spaces.2.patch (1.7 KB) - added by cypherpunks 3 years ago.

Download all attachments as: .zip

Change History (11)

Changed 4 years ago by cypherpunks

Attachment: 0001-Fix-PEP8-errors.patch added

Changed 4 years ago by cypherpunks

comment:1 Changed 4 years ago by cypherpunks

Status: newneeds_review

comment:2 Changed 4 years ago by cypherpunks

This ticket is now blocking progress in #14332 and #16904 because they both would cause merge conflicts with these patches. Let me know if i can do anything to speed up the process.

comment:3 Changed 3 years ago by nickm

Owner: changed from nickm to cypherpunks
Status: needs_reviewassigned

comment:4 Changed 3 years ago by nickm

Status: assignedneeds_review

comment:5 Changed 3 years ago by nickm

Status: needs_reviewneeds_revision

patches no longer apply, I'm afraid.

Changed 3 years ago by cypherpunks

Changed 3 years ago by cypherpunks

comment:6 Changed 3 years ago by cypherpunks

Status: needs_revisionneeds_review

The newly attached patches have been rebased on the current master. Also rechecked for PEP8 violations and no new violations were found.

comment:7 Changed 3 years ago by nickm

Keywords: TorCoreTeam201606 added
Resolution: fixed
Sponsor: SponsorS-can
Status: needs_reviewclosed

lgtm; merged. Thanks!

Note: See TracTickets for help on using tickets.