Opened 4 years ago

Closed 3 years ago

#18196 closed enhancement (fixed)

Write options_validate tests for RSOS

Reported by: teor Owned by: teor
Priority: Medium Milestone: Tor: 0.2.9.x-final
Component: Core Tor/Tor Version:
Severity: Normal Keywords: rsos, tor-hs, TorCoreTeam201607
Cc: Actual Points: 0.3
Parent ID: #17178 Points: 2
Reviewer: Sponsor:

Description

In #17178, we add RendezvousSingleOnionNonAnonymousServer.
In #17788, I propose to add RendPolicy and RendPolicyRejectPrivate.

But I want to wait for #17076 to be reviewed and merged before writing options_validate unit tests for these options.

Child Tickets

Change History (9)

comment:1 Changed 4 years ago by teor

#17076 has been merged. Awaiting #17788 and maybe a review on #17178.

comment:2 Changed 4 years ago by teor

#17178 has been reviewed, not sure if it will make it into 0.2.8.
#17788 will add ExtendPolicy, and it's in 0.2.9, so I'll deal with the options tests in that ticket.

comment:3 Changed 4 years ago by nickm

Milestone: Tor: 0.2.8.x-finalTor: 0.2.9.x-final

Throw most 0.2.8 "NEW" tickets into 0.2.9. I expect that many of them will subsequently get triaged out.

comment:4 Changed 4 years ago by teor

Milestone: Tor: 0.2.9.x-finalTor: 0.2.8.x-final

I need to write unit tests for the following options and option behaviour changes:

  • RendezvousSingleOnionNonAnonymousServer
  • Don't allow hotplugging of RSOS
  • Mark RSOS HSes so that they don't start up as anonymous
    • Requires filesystem, could be better as a script-based check)
  • Disable LearnCircuitBuildTimeout and UseEntryGuards with RSOS
  • Make sure anonymous clients can't be configured with RSOS
  • Make sure Tor2web doesn't allow hidden services to be configured
    • Requires compilation options?

comment:5 Changed 4 years ago by nickm

Milestone: Tor: 0.2.8.x-finalTor: 0.2.9.x-final

These seem like features, or like other stuff unlikely to be possible this month. Bumping them to 0.2.9

comment:6 Changed 4 years ago by asn

Keywords: tor-hs added
Points: small/medium

comment:7 Changed 4 years ago by nickm

Keywords: TorCoreTeam201602 removed

comment:8 Changed 3 years ago by nickm

Points: small/medium2

small/medium => 2.

comment:9 Changed 3 years ago by teor

Actual Points: 0.3
Keywords: TorCoreTeam201607 added
Resolution: fixed
Status: newclosed

This is implemented in #17178

Note: See TracTickets for help on using tickets.