Opened 3 years ago

Last modified 2 years ago

#18224 assigned defect

Tor control spec doesn't properly specify reply format

Reported by: cypherpunks Owned by: gk
Priority: Medium Milestone: Tor: unspecified
Component: Core Tor/Tor Version:
Severity: Normal Keywords: tor-spec, tor-control
Cc: gk, brade, mcs Actual Points:
Parent ID: #17607 Points:
Reviewer: Sponsor:

Description

The control spec does not sufficiently specify how to generically parse multi line replies from the controller. The intent seems to be that multi line response data is terminated by a '.' line.

However, this is not specified in the control spec section 2.3 and the reply description there is insufficient to properly recognize multi-line reply packets leading to bugs like:
https://trac.torproject.org/projects/tor/ticket/16990

Child Tickets

Change History (10)

comment:1 Changed 3 years ago by gk

Cc: gk added
Keywords: tor-spec tor-controller added

comment:2 Changed 3 years ago by mcs

Cc: brade mcs added

comment:3 Changed 3 years ago by gk

Owner: set to gk
Parent ID: #17607
Status: newassigned

Might be good doing that as part of the section 2 clean-up I am working on anyway. Assigning this to me.

comment:4 Changed 3 years ago by nickm

Milestone: Tor: 0.2.???

I'll take a patch here if somebody writes one

comment:5 Changed 3 years ago by teor

Milestone: Tor: 0.2.???Tor: 0.3.???

Milestone renamed

comment:6 Changed 2 years ago by nickm

Keywords: tor-03-unspecified-201612 added
Milestone: Tor: 0.3.???Tor: unspecified

Finally admitting that 0.3.??? was a euphemism for Tor: unspecified all along.

comment:7 Changed 2 years ago by nickm

Keywords: tor-03-unspecified-201612 removed

Remove an old triaging keyword.

comment:8 Changed 2 years ago by dgoulet

Keywords: controller added

Unify controller keyword to "tor-control".

comment:9 Changed 2 years ago by dgoulet

Keywords: tor-control added; controller removed

Unify "controller" keyword to "tor-control".

comment:10 Changed 2 years ago by dgoulet

Keywords: tor-controller removed

Cleanup remaining "tor-controller" that already have "tor-control"

Note: See TracTickets for help on using tickets.