Opened 4 years ago

Closed 4 years ago

#18235 closed defect (fixed)

Disable Facebook

Reported by: arlolra Owned by:
Priority: Medium Milestone:
Component: Archived/Tor Messenger Version:
Severity: Normal Keywords:
Cc: sukhbir Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Facebook's XMPP gateway, long officially deprecated, doesn't appear to work anymore.

https://bugzilla.mozilla.org/show_bug.cgi?id=1236133#c0

Need to apply,
https://hg.mozilla.org/comm-central/rev/4f1b3e5af8ef
and adapt for #13323.

Also, close down #17464 and remove all the places we mention Facebook support (project page, faq, etc).

On a brighter note though, I believe there's a libpurple implementation, so hope that a JS prpl will emerge, and someone on IRC was mentioning working on it during GSoC.

The new protocol is based on mqtt.

Child Tickets

Change History (5)

comment:1 Changed 4 years ago by sukhbir

Please review 477642edb5e.

In addition to the above patch, we are removing facebook.js from the package manifest. The protocol screen has been updated and Twitter is in the top protocols instead of FB.

comment:2 Changed 4 years ago by arlolra

The patch looks problematic.

If someone already has a facebook account setup, what's this patch going to do? It looks like it'll throw something nasty. Can you try creating a facebook account then applying this patch and seeing what happens on it?

Also, until you have gerrit setup, can you push a branch to github and make a pull request for review, rather than pushing to master?

comment:3 in reply to:  2 Changed 4 years ago by sukhbir

Replying to arlolra:

The patch looks problematic.

If someone already has a facebook account setup, what's this patch going to do? It looks like it'll throw something nasty. Can you try creating a facebook account then applying this patch and seeing what happens

Given that we have no updater, how will that work? This patch will go in the next release of Tor Messenger, on a new user profile so there will be no existing accounts.

Also, until you have gerrit setup, can you push a branch to github and make a pull request for review, rather than pushing to master?

(OK from next time.)

comment:4 Changed 4 years ago by arlolra

Given that we have no updater, how will that work? This patch will go in the next release of Tor Messenger, on a new user profile so there will be no existing accounts.

That's a good point. Nevertheless, the profile is just a directory nested in the application folder. You can copy it from one to the other. And, there wasn't much of a need to diverge from what aleth did.

Also, maybe a good time to have done comment:6:ticket:13323 since that list is now even shorter.

Anyways, I'm fine with closing this as implemented if you want.

comment:5 in reply to:  4 Changed 4 years ago by sukhbir

Resolution: fixed
Status: newclosed

Replying to arlolra:

Given that we have no updater, how will that work? This patch will go in the next release of Tor Messenger, on a new user profile so there will be no existing accounts.

That's a good point. Nevertheless, the profile is just a directory nested in the application folder. You can copy it from one to the other. And, there wasn't much of a need to diverge from what aleth did.

Also, maybe a good time to have done comment:6:ticket:13323 since that list is now even shorter.

Anyways, I'm fine with closing this as implemented if you want.

I agree with your concern but we are assuming that a new profile is created on a fresh install since copying profiles may cause other problems that we have not thought about (and we don't recommend that). So let's go with this for now.

Note: See TracTickets for help on using tickets.