remove unused code and strings from Torbutton

While waiting for Tor Browser builds to finish, Kathy started to look at what code and strings could be removed from Torbutton. This will be done with a series of patches to make review easier.

added TorBrowserTeam201605R component::applications/tor browser owner::brade priority::medium resolution::fixed severity::normal status::closed tbb-torbutton type::defect labels

See #18233 (moved) for a suggestion on things to remove.

For now, our focus is on removing dead code and strings that are not used by any existing features of Torbutton. Here is the first patch: https://gitweb.torproject.org/user/brade/torbutton.git/commit/?h=bug18238-A-01&id=39402307e28599be8658762047c9a59cdc3d91c0

Here is an additional patch that removes some more entities: https://gitweb.torproject.org/user/brade/torbutton.git/commit/?h=bug18238-A-01&id=afa935ddc29c5e26855ea76c77f2a57ee015fa09

Kathy and I noticed that the toolbarbutton (defined in src/chrome/content/torbutton.xul) has a hard-coded label of "Torbutton". Should it stay that way or should the button label be localized?

There is an unused entity named torbutton.button.label that is not otherwise used; it seems likely that it was intended for this purpose. But maybe this is a branding issue and we should keep the hard-coded Torbutton label and just remove the unused entity.

Trac:
Status: new to needs_information
Keywords: N/A deleted, TorBrowserTeam201602 added

Replying to mcs:

But maybe this is a branding issue and we should keep the hard-coded Torbutton label and just remove the unused entity.

Yes, this sounds like a good idea.

Trac:
Status: needs_information to assigned

Replying to gk:

Replying to mcs:

But maybe this is a branding issue and we should keep the hard-coded Torbutton label and just remove the unused entity.

Yes, this sounds like a good idea.

I am OK with this decision; I will remove the unused entity.
I do want to point out that it could be an issue if someone someone in China (or other locales) has an icon on their toolbar that has English text instead of their locale: it would stand out and a passerby could easily notice. However, the default is that toolbar icons do not have a text label so this seems like a less likely scenario.

Trac:
Keywords: TorBrowserTeam201602 deleted, TorBrowserTeam201603 added

We left the month of March behind a couple of weeks ago.

Trac:
Keywords: TorBrowserTeam201603 deleted, TorBrowserTeam201604 added

Since some of this work is done, we should consider merging it for the upcoming alpha release. There are three commits on brade's bug18238-01 branch that are ready for review, here: https://gitweb.torproject.org/user/brade/torbutton.git/log/?h=bug18238-01 (please ignore the patches mentioned earlier in this ticket).

Trac:
Reviewer: N/A to N/A
Keywords: TorBrowserTeam201604 deleted, TorBrowserTeam201605R added
Status: assigned to needs_review

Looks good to me. This is commit 8eaca2e12c9c90c8af1cc85817956c2e1f554e52, e8f694c4fb513c92ec26603fdaa3be745d7648a5 and 58d67d50eb41caf0493126a859646a476d6700f4 on master.

Trac:
Resolution: N/A to fixed
Status: needs_review to closed

I filed #19256 (moved) for followup work.

closed

mentioned in issue #19256 (moved)

moved to tpo/applications/tor-browser#18238 (closed)

mentioned in issue tpo/applications/torbutton#19256 (closed)