Opened 20 months ago

Closed 20 months ago

Last modified 18 months ago

#18251 closed defect (fixed)

circuitmux_detach_all_circuits: Assertion to_remove->muxinfo.policy_data == NULL failed

Reported by: s7r Owned by:
Priority: High Milestone: Tor: 0.2.8.x-final
Component: Core Tor/Tor Version: Tor: 0.2.8.1-alpha
Severity: Major Keywords: 2016-bug-retrospective
Cc: andrea Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

After upgrading from 0.2.8.0 to 0.2.8.1 on a relay. Upgrade or start of 0.2.8.1 (after upgrade) were not affected apparently.

Feb 05 13:05:09.000 [notice] Clean shutdown finished. Exiting.
Feb 05 13:05:09.000 [warn] Couldn't find circuit 2642529256 (for channel 924182)
Feb 05 13:05:09.000 [err] tor_assertion_failed_(): Bug: ../src/or/circuitmux.c:501: circuitmux_detach_all_circuits: Assertion to_remove->muxinfo.policy_data == NULL failed; aborting. (on Tor 0.2.8.0-alpha-dev )
Feb 05 13:05:09.000 [err] Bug: Assertion to_remove->muxinfo.policy_data == NULL failed in circuitmux_detach_all_circuits at ../src/or/circuitmux.c:501. Stack trace: (on Tor 0.2.8.0-alpha-dev )
Feb 05 13:05:09.000 [err] Bug:     /usr/bin/tor(log_backtrace+0x42) [0x7f225673f7c2] (on Tor 0.2.8.0-alpha-dev )
Feb 05 13:05:09.000 [err] Bug:     /usr/bin/tor(tor_assertion_failed_+0x9f) [0x7f225674d48f] (on Tor 0.2.8.0-alpha-dev )
Feb 05 13:05:09.000 [err] Bug:     /usr/bin/tor(circuitmux_detach_all_circuits+0x299) [0x7f22566cb149] (on Tor 0.2.8.0-alpha-dev )
Feb 05 13:05:09.000 [err] Bug:     /usr/bin/tor(+0xae27d) [0x7f22566b827d] (on Tor 0.2.8.0-alpha-dev )
Feb 05 13:05:09.000 [err] Bug:     /usr/bin/tor(channel_free_all+0x8f) [0x7f22566b876f] (on Tor 0.2.8.0-alpha-dev )
Feb 05 13:05:09.000 [err] Bug:     /usr/bin/tor(tor_free_all+0x7f) [0x7f225664d59f] (on Tor 0.2.8.0-alpha-dev )
Feb 05 13:05:09.000 [err] Bug:     /usr/bin/tor(tor_cleanup+0x2c) [0x7f225664d71c] (on Tor 0.2.8.0-alpha-dev )
Feb 05 13:05:09.000 [err] Bug:     /usr/bin/tor(consider_hibernation+0xf9) [0x7f22567386d9] (on Tor 0.2.8.0-alpha-dev )
Feb 05 13:05:09.000 [err] Bug:     /usr/bin/tor(+0x41840) [0x7f225664b840] (on Tor 0.2.8.0-alpha-dev )
Feb 05 13:05:09.000 [err] Bug:     /usr/lib/x86_64-linux-gnu/libevent-2.0.so.5(event_base_loop+0x414) [0x7f2255d18254] (on Tor 0.2.8.0-alpha-dev )
Feb 05 13:05:09.000 [err] Bug:     /usr/bin/tor(do_main_loop+0x225) [0x7f225664c965] (on Tor 0.2.8.0-alpha-dev )
Feb 05 13:05:09.000 [err] Bug:     /usr/bin/tor(tor_main+0x1c5d) [0x7f225665001d] (on Tor 0.2.8.0-alpha-dev )
Feb 05 13:05:09.000 [err] Bug:     /usr/bin/tor(main+0x19) [0x7f2256648749] (on Tor 0.2.8.0-alpha-dev )
Feb 05 13:05:09.000 [err] Bug:     /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xfd) [0x7f2254f35ead] (on Tor 0.2.8.0-alpha-dev )
Feb 05 13:05:09.000 [err] Bug:     /usr/bin/tor(+0x3e799) [0x7f2256648799] (on Tor 0.2.8.0-alpha-dev )
Feb 05 13:05:18.000 [notice] Tor 0.2.8.1-alpha-dev (git-1f5cdf2b6c72ae89+26ab2e0) opening log file.

Child Tickets

Change History (6)

comment:1 Changed 20 months ago by s7r

Exact git commit is Tor 0.2.8.0-alpha-dev (git-d062baac86c824f8+2e27d52

comment:2 Changed 20 months ago by nickm

Priority: MediumHigh
Severity: NormalMajor

comment:3 Changed 20 months ago by nickm

Cc: andrea added
Status: newneeds_information

I've just merged a fix for #18116, which seems as though it might fix this too. Please let me know if you can reproduce this issue with ee75c02691888a0cb7ee34e4f18436c523f92f0d or later.

comment:4 Changed 20 months ago by s7r

I am thinking how to reproduce it. I didn't do anything special last time, it happened after the sigterm or sigint was sent (to replace files and upgrade to 0.2.8.1). I will try on a fast relay with the commit you suggested by sending few sigterm signals and comment here if I can reproduce.

comment:5 Changed 20 months ago by s7r

Resolution: fixed
Status: needs_informationclosed

I tried hard to reproduce hard with ee75c02691888a0cb7ee34e4f18436c523f92f0d and didn't get it, so I think we can safely call this fixed along with #18116. Will reopen in case the bug still affects relays.

comment:6 Changed 18 months ago by nickm

Keywords: 2016-bug-retrospective added

Marking these tickets (based on severity and hand-review) for inclusion in 2016 bug retrospective

Note: See TracTickets for help on using tickets.