Code cleanup, aes.c/crypto.c

Removed aes_crypt, left only aes_crypt_inplace. Removed should_use_openssl_CTR, was used for openssl 1.0.0 counter bug.

Trac:
Username: malekbr

changed milestone to %Tor: 0.2.8.x-final

added component::core tor/tor milestone::Tor: 0.2.8.x-final priority::very low reporter::malekbr resolution::fixed severity::trivial status::closed type::enhancement labels

The repo: https://github.com/malekbr/tor The branch: cleaned_aes_crypt

Trac:
Username: malekbr

Trac:
Username: malekbr
Status: new to needs_review

Trac:
Milestone: N/A to Tor: 0.2.8.x-final

-  if (fast_memneq(output, encrypt_zero, 16)) {
-    /* Counter mode is buggy */
-    log_notice(LD_CRYPTO, "This OpenSSL has a buggy version of counter mode; "
-               "not using it.");
-  } else {
-    /* Counter mode is okay */
-    log_info(LD_CRYPTO, "This OpenSSL has a good implementation of counter "
-               "mode; using it.");
-    should_use_openssl_CTR = 1;
-  }

It might be cool to keep the check code, and instead of giving a log_notice() in the bug case, give a log_err() and exit.

Also, does anything still use aes_cnt_cipher.buf and aes_fill_buffer? If not, can we throw them out?

Trac:
Status: needs_review to needs_revision

It appears .buf is needed, aes_fill_buffer isn't.

Trac:
Username: malekbr
Status: needs_revision to needs_review

ok. I squashed those and added a changes file and merged. Thanks!

Trac:
Resolution: N/A to fixed
Status: needs_review to closed

closed

moved to tpo/core/tor#18258 (closed)