Opened 5 years ago

Closed 5 years ago

#18261 closed defect (fixed)

socket listening defer code segfaults when no user is set

Reported by: weasel Owned by:
Priority: Medium Milestone: Tor: 0.2.8.x-final
Component: Core Tor/Tor Version: Tor: 0.2.8.1-alpha
Severity: Normal Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

<weasel> +    if (port->is_unix_addr && !geteuid() && strcmp(options->User, "root"))
<weasel> +      continue;
<weasel> is options->User guaranteed to be set?

Nope, it's not, as nickm, arma, and weasel concur:
Tor 0.2.8.1-alpha-dev (git-1f5cdf2b6c72ae89) died: Caught signal 11

#2  0x00007f2079b2994c in crash_handler (sig=<optimized out>, si=<optimized out>, ctx_=<optimized out>) at ../src/common/backtrace.c:144
#3  <signal handler called>
#4  0x00007f2079ada53e in retry_listener_ports (control_listeners_only=<optimized out>, new_conns=<optimized out>, ports=<optimized out>, old_conns=<optimized out>) at ../src/or/connection.c:2401

Child Tickets

Change History (4)

comment:1 Changed 5 years ago by nickm

Milestone: Tor: 0.2.8.x-final

comment:3 Changed 5 years ago by nickm

Merging!

comment:4 Changed 5 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

Merging!

Note: See TracTickets for help on using tickets.