Opened 10 years ago

Closed 10 years ago

Last modified 8 years ago

#1830 closed defect (fixed)

perconnbwrate/burst not reset when config options change

Reported by: arma Owned by: arma
Priority: Medium Milestone: Deliverable-Sep2010
Component: Core Tor/Tor Version:
Severity: Keywords: tor-relay
Cc: Actual Points:
Parent ID: #1750 Points:
Reviewer: Sponsor:


If I have perconnbwrate/burst set to something, and an OR conn arrives, the rate and burst for that conn are chosen forevermore at that moment. If I later change the config options and hup, new OR conns get the new options, but old ones stay as they are.

This is going to become even more apparent once we put the options in the consensus. Our experiments won't produce the results we want because they'll be spoiled by already-established OR conns.

So we should walk through all the OR conns whenever those options change (including if they change in the consensus), and reset rate and burst to the new rate and burst, and if the bucket is now higher than burst, set it back to burst too.

Child Tickets

Change History (5)

comment:1 Changed 10 years ago by arma

Oh hey, there's an even more fun bug lurking here too.

Relay A starts up, isn't in the consensus yet, connects to you, holds a few circuits open and thus the OR conn open. You give him the perconnbwrate and burst since he's not a relay.

Later he gets into the consensus, and clients start asking you to extend to him.

You're still using the old perconnbwrate/burst for him.

Sounds like we need to reset all our or_conn rates and bursts not just when the perconnbwrate/burst config options (or consensus params) change, but also every time the consensus changes, in case the set of who's not a relay has changed.

comment:2 Changed 10 years ago by arma

Should be solved now, as of 8d588e7b1a4fc

The follow-up question now is whether we should rename the consensus params, since Tor through will experience the ugly edge case where they throttle relays. I'm not sure how common said edge case is in practice.

comment:3 Changed 10 years ago by arma

Resolution: fixed
Status: newclosed

Opened #1947 to reflect the "follow-up question" above.

Closing this one as fixed.

comment:4 Changed 8 years ago by nickm

Keywords: tor-relay added

comment:5 Changed 8 years ago by nickm

Component: Tor RelayTor
Note: See TracTickets for help on using tickets.