Build TBBs Tor with -ftrapv

The TBB build process for Tor should build Tor with -ftrapv.

Related tickets: https://trac.torproject.org/projects/tor/ticket/18296 https://trac.torproject.org/projects/tor/ticket/17983

added component::applications/tor browser owner::tbb-team priority::medium resolution::wontfix severity::normal status::closed type::defect labels

We built tor with -ftrapv by default early in the 0.2.9 series, then backed this out as a denial of service risk (#21290 (moved)).

I would strongly recommend we don't build Tor Browser's tor with -ftrapv by default.

More information: https://trac.torproject.org/projects/tor/wiki/doc/TorFragileHardening

Discussion on tbb-dev about the tbb "hardened" series: https://lists.torproject.org/pipermail/tbb-dev/2017-February/000457.html

Trac:
Reviewer: N/A to N/A

Replying to teor:

We built tor with -ftrapv by default early in the 0.2.9 series, then backed this out as a denial of service risk (#21290 (moved)).

I would strongly recommend we don't build Tor Browser's tor with -ftrapv by default.

Agreed.

Trac:
Status: new to closed
Resolution: N/A to wontfix

closed

mentioned in issue #18859 (moved)

moved to tpo/applications/tor-browser#18310 (closed)