Opened 4 years ago

Last modified 8 weeks ago

#18325 new enhancement

We should not depend on rebuilding Firefox to get a new Tor Browser version out

Reported by: gk Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-rbm, gitlab-tb-tor-browser-build
Cc: boklm, mcs, brade Actual Points:
Parent ID: Points:
Reviewer: Sponsor:


In case we need to bump OpenSSL or think about just rebundling for a new release we need to rebuild Firefox too, currently, as the Tor Browser version is getting set there. We should find a way to avoid that.

Child Tickets

#18326defectnewtbb-teamCreating incremental MAR files should not include Tor Browser version in meta data

Change History (5)

comment:1 Changed 4 years ago by gk

Now that we parse the changelog for showing the things we fixed in an update can't we use a mechanism like that to extract the version number on (first-start) as well?

Or, if all things fail, we could inject the version number in the bundling step I guess which is kind of hacky, too.

Any better alternatives I am currently missing?

comment:2 Changed 4 years ago by mcs

I do not think it will be easy to avoid embedding the version at compile time. Aside from #18326, there is also some compiled code that needs to have access to the version before the user profile has been loaded (for an example, search for TOR_BROWSER_VERSION inside toolkit/xre/nsAppRunner.cpp). But I have not thought about this a lot.

comment:3 Changed 3 years ago by gk

I just hit this again while trying to just bump the tor version in 7.5a2. :(

comment:4 Changed 3 years ago by gk

Keywords: tbb-rbm added; tbb-gitian removed

Moving over to rbm

comment:5 Changed 8 weeks ago by gk

Keywords: gitlab-tb-tor-browser-build added

Add magic gitlab keyword.

Note: See TracTickets for help on using tickets.